Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IsCardanoEra constraint to BlockInMode #3665

Merged
merged 1 commit into from
May 13, 2022
Merged

Add IsCardanoEra constraint to BlockInMode #3665

merged 1 commit into from
May 13, 2022

Conversation

andreabedini
Copy link
Contributor

This PR adds the IsCardanoEra constraint to BlockInMode.

data BlockInMode mode where
     BlockInMode :: IsCardanoEra era => Block era -> EraInMode era mode -> BlockInMode mode

The additional constraints makes it easier to use BlockInMode with types like SomeCardanoApiTx which require IsCardanoEra.

Please let me know if I am missing something obvious.

@andreabedini
Copy link
Contributor Author

Hi @Jimbo4350 could you have a look?

nc6
nc6 approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@nc6 nc6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks completely reasonable to me. Note that we still have IsCardanoEra for single-era modes, so I can't see this causing any problems.

@nc6
Copy link
Contributor

nc6 commented May 13, 2022

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 13, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 91a11ba into master May 13, 2022
@iohk-bors iohk-bors bot deleted the andrea/patch-1 branch May 13, 2022 10:50
@andreabedini andreabedini mentioned this pull request May 23, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nc6 nc6 nc6 approved these changes

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreabedini @nc6