Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for membench benchmarks #3705

Merged
merged 5 commits into from
Mar 15, 2022
Merged

Prepare for membench benchmarks #3705

merged 5 commits into from
Mar 15, 2022

Conversation

jutaro
Copy link
Contributor

@jutaro jutaro commented Mar 14, 2022

Add configurations to old and new tracing to make it comparable.

@jutaro jutaro self-assigned this Mar 14, 2022
@jutaro jutaro requested a review from JaredCorduan as a code owner March 14, 2022 13:31
@deepfire deepfire force-pushed the jutaro/membench-tracers branch from ce53b6c to 20d2119 Compare March 14, 2022 16:35
@deepfire deepfire force-pushed the jutaro/membench-tracers branch from 20d2119 to 9613a3f Compare March 14, 2022 16:37
deepfire
deepfire approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

Thanks a lot @jutaro !

iohk-bors bot added a commit that referenced this pull request Mar 14, 2022
@iohk-bors @jutaro
Merge #3705
5706673 
3705: Prepare for membench benchmarks r=deepfire a=jutaro

Add configurations to old and new tracing to make it comparable.

Co-authored-by: Yupanqui <jnf@arcor.de>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 14, 2022

Build failed:

@deepfire
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request Mar 14, 2022
@iohk-bors @jutaro @deepfire
Merge #3705
aae0382 
3705: Prepare for membench benchmarks r=deepfire a=jutaro

Add configurations to old and new tracing to make it comparable.

Co-authored-by: Yupanqui <jnf@arcor.de>
Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 14, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from DavidEichmann, JaredCorduan, Jimbo4350, dcoutts, erikd, nc6, and/or newhoggy.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@deepfire
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 15, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit a3fc02b into master Mar 15, 2022
@iohk-bors iohk-bors bot deleted the jutaro/membench-tracers branch March 15, 2022 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

@deepfire deepfire deepfire approved these changes

@denisshevchenko denisshevchenko Awaiting requested review from denisshevchenko

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

@nc6 nc6 Awaiting requested review from nc6

Assignees

@jutaro jutaro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jutaro @deepfire @JaredCorduan