Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tracers without prototypes #3731

Merged
merged 6 commits into from
Apr 4, 2022
Merged

New tracers without prototypes #3731

merged 6 commits into from
Apr 4, 2022

Conversation

jutaro
Copy link
Contributor

@jutaro jutaro commented Mar 31, 2022

Remove the prototype concept from the tracer library and replace it with using Namespaces for documentation and configuration.

@jutaro jutaro changed the title New tracers withou prototypes New tracers without prototypes Mar 31, 2022
@jutaro jutaro force-pushed the jutaro/bench-tracers branch 2 times, most recently from 3456435 to 32b12a7 Compare April 1, 2022 09:54
@jutaro jutaro marked this pull request as ready for review April 1, 2022 09:58
@Jimbo4350 Jimbo4350 self-requested a review April 1, 2022 15:36
Jimbo4350
Jimbo4350 requested changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jutaro Can you clean up the commit history and improve the commit descriptions? They are somewhat opaque. For example having a commit per tracing module that has been updated would be clearer.

@deepfire deepfire force-pushed the jutaro/bench-tracers branch from b2e476f to 9e5d2f0 Compare April 1, 2022 16:03
@Jimbo4350 Jimbo4350 self-requested a review April 1, 2022 16:05
@deepfire deepfire force-pushed the jutaro/bench-tracers branch 2 times, most recently from 57e4859 to d229ba1 Compare April 1, 2022 20:28
@deepfire deepfire force-pushed the jutaro/bench-tracers branch from d229ba1 to 4baca47 Compare April 1, 2022 20:39
newhoggy
newhoggy requested changes Apr 2, 2022
View reviewed changes
Copy link
Contributor

@newhoggy newhoggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

@newhoggy newhoggy self-requested a review April 4, 2022 11:18
@Jimbo4350 Jimbo4350 self-requested a review April 4, 2022 12:39
@deepfire deepfire force-pushed the jutaro/bench-tracers branch from 1a507b4 to 92e430f Compare April 4, 2022 19:28
@jutaro
Copy link
Contributor Author

jutaro commented Apr 4, 2022

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 4, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 16891f4 into master Apr 4, 2022
@iohk-bors iohk-bors bot deleted the jutaro/bench-tracers branch April 4, 2022 20:05
@newhoggy newhoggy mentioned this pull request Apr 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepfire deepfire deepfire approved these changes

@newhoggy newhoggy newhoggy approved these changes

@denisshevchenko denisshevchenko Awaiting requested review from denisshevchenko

@coot coot Awaiting requested review from coot

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@nc6 nc6 Awaiting requested review from nc6

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jutaro @newhoggy @deepfire @Jimbo4350