Install a dummy SIGHUP handler for non p2p mode #3896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnadales
reviewed
May 24, 2022
coot
requested review from
deepfire,
denisshevchenko,
jutaro,
DavidEichmann,
dcoutts,
erikd,
newhoggy,
nc6 and
JaredCorduan
as code owners
When sending SIGHUP handler, p2p will reload the configuration, while non-p2p will exit. Instead of that we install a dummy handler, which logs that topology reloading for non-p2p is not supported, which prevents haskell runtime to use the default signal handler (which forces the process to exit). Fixes #3872.
Jimbo4350
approved these changes
May 25, 2022
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
May 30, 2022
3896: Install a dummy SIGHUP handler for non p2p mode r=coot a=coot When sending SIGHUP handler, p2p will reload the configuration, while non-p2p will exit. Instead of that we install a dummy handler, which logs that topology reloading for non-p2p is not supported, which prevents haskell runtime to use the default signal handler (which forces the process to exit). Fixes #3872. Co-authored-by: Marcin Szamotulski <coot@coot.me>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from deepfire, denisshevchenko, and/or jutaro.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
denisshevchenko
approved these changes
May 30, 2022
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
May 30, 2022
3896: Install a dummy SIGHUP handler for non p2p mode r=coot a=coot When sending SIGHUP handler, p2p will reload the configuration, while non-p2p will exit. Instead of that we install a dummy handler, which logs that topology reloading for non-p2p is not supported, which prevents haskell runtime to use the default signal handler (which forces the process to exit). Fixes #3872. Co-authored-by: Marcin Szamotulski <coot@coot.me>
|
Build failed: |
newhoggy
approved these changes
May 30, 2022
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 1, 2022
3896: Install a dummy SIGHUP handler for non p2p mode r=coot a=coot When sending SIGHUP handler, p2p will reload the configuration, while non-p2p will exit. Instead of that we install a dummy handler, which logs that topology reloading for non-p2p is not supported, which prevents haskell runtime to use the default signal handler (which forces the process to exit). Fixes #3872. Co-authored-by: Marcin Szamotulski <coot@coot.me>
|
Timed out. |
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 3, 2022
3896: Install a dummy SIGHUP handler for non p2p mode r=coot a=coot When sending SIGHUP handler, p2p will reload the configuration, while non-p2p will exit. Instead of that we install a dummy handler, which logs that topology reloading for non-p2p is not supported, which prevents haskell runtime to use the default signal handler (which forces the process to exit). Fixes #3872. Co-authored-by: Marcin Szamotulski <coot@coot.me>
|
Timed out. |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending SIGHUP handler, p2p will reload the configuration, while
non-p2p will exit. Instead of that we install a dummy handler, which
logs that topology reloading for non-p2p is not supported, which
prevents haskell runtime to use the default signal handler (which forces
the process to exit).
Fixes #3872.