Replace usage of QueryGenesisParameters by one that only fetches KES parameters #4551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartfrenk
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy,
JaredCorduan,
LudvikGalois and
CarlosLopezDeLara
as code owners
7 tasks
|
This PR is stale because it has been open 45 days with no activity. |
Jimbo4350
requested changes
Jan 3, 2023
| } | ||
|
|
||
|
|
||
| data KESConfig = KESConfig { |
There was a problem hiding this comment.
This information is obtainable via the kes-period-info command.
|
Closing. See #4551 (comment) |
nfrisby
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal to remove usage of the bulky
QueryGenesisParametersquery from ouroboros-network, by a new, lighter query,GetKESConfig. As I see it, merging this PR would have the following benefit of reducing the interface betweencardano-nodeandouroboros-consensus.The PR that introduces the
GetKESConfigquery inouroboros-consensusis IntersectMBO/ouroboros-network#4156.Also, there is probably additional cleaning up to do, e.g., removing parts of Cardano.Api.GenesisParameters. Again, I have postponed doing that until green light.