Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stack build #135

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Remove stack build #135

merged 1 commit into from
Oct 19, 2020

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Oct 19, 2020

As suggested by this comment: #121 (comment)

@newhoggy newhoggy force-pushed the remove-stack-build branch 2 times, most recently from 02c8423 to 28ff54a Compare October 19, 2020 02:40
@newhoggy newhoggy requested review from jbgi, nfrisby, johnalotoski, rvl, erikd, intricate and Jimbo4350 and removed request for jbgi and nfrisby October 19, 2020 02:46
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -1,22 +1,40 @@
{ system ? builtins.currentSystem
, crossSystem ? null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scrips/buildkite directory could be deleted, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left the cabal check buildkite script there, but can delete if preferred.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cabal check is removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build failed when I removed it so I put it back. Maybe remove it in a future PR.

@newhoggy newhoggy force-pushed the remove-stack-build branch 2 times, most recently from 0f5c48f to 4000bee Compare October 19, 2020 06:57
@newhoggy
Copy link
Contributor Author

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 19, 2020

@iohk-bors iohk-bors bot merged commit f5ace10 into master Oct 19, 2020
@iohk-bors iohk-bors bot deleted the remove-stack-build branch October 19, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants