Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance failure: Empty withdrawals are valid in the spec but not in the implementation #654

Closed
Soupstraw opened this issue Jan 28, 2025 · 2 comments · Fixed by #661
Closed

Comments

@Soupstraw
Copy link
Contributor

test.txt

@WhatisRT
Copy link
Collaborator

Ah, this is about treasury withdrawals, not the regular kind. This is one of those mechanisms that I'd rather have seen implemented in the mempool, but I guess it's what we have now.

What exactly does the implementation prevent here? The empty map and zeros in the map?

@Soupstraw
Copy link
Contributor Author

Yeah, sorry, I meant treasury withdrawals. The implementation does not allow a treasury withdrawal that sums up to zero:

https://github.com/IntersectMBO/cardano-ledger/blob/master/eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Gov.hs#L509-L511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants