Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow empty withdrawal proposals #661

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

Soupstraw
Copy link
Contributor

Description

resolves #654

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Any semantic changes to the specifications are documented in CHANGELOG.md
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/empty-withdrawals branch from 894ad8b to f00ad55 Compare January 31, 2025 12:55
Copy link
Collaborator

@WhatisRT WhatisRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WhatisRT WhatisRT merged commit 984f37f into master Jan 31, 2025
6 of 9 checks passed
@WhatisRT WhatisRT deleted the jj/empty-withdrawals branch January 31, 2025 13:10
github-actions bot added a commit that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conformance failure: Empty withdrawals are valid in the spec but not in the implementation
3 participants