Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss changing the well-formedness check of TreasuryWdrl #664

Open
WhatisRT opened this issue Jan 31, 2025 · 1 comment
Open

Discuss changing the well-formedness check of TreasuryWdrl #664

WhatisRT opened this issue Jan 31, 2025 · 1 comment

Comments

@WhatisRT
Copy link
Collaborator

We've had a small discussion that it might make more sense to just forbid zeros entirely in TreasuryWdrl, rather than to just force a single non-zero entry. We can't change it now, but it might be something to do for the future.

@WhatisRT
Copy link
Collaborator Author

This situation is also a good example for why striving for concise notation is a good thing. It's much less obvious that this is weird when buried deep inside big functions somewhere: https://github.com/IntersectMBO/cardano-ledger/blob/master/eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Gov.hs#L511

Also, apparently I've already complained that this type of check would have been better in the mempool: IntersectMBO/cardano-ledger#4582 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant