-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
652 remove superscripts from rec constr #655
Conversation
c56a925
to
b08b87f
Compare
This is currently blocked by #653 |
675be19
to
ef77a0e
Compare
This closes issue #653. (It may be as simple as removing the extra new line character `+ \n` from the `file.write` line in the `write_file` function.)
8c1cc29
to
f5a6fb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this, but it's a shame that we're losing some of the patterns here. I think some of them should be resurrected. Here's the most obvious place where things got worse. Before:
Obviously this has other issues as well, but in the before it's really easy to see what changed and maybe more crucially what didn't change (and that e.g. the reserves and treasury didn't get swapped), and in the after this is completely gone (and just adding the vertical vectors back in isn't going to fix it). There are a few other places such as UTXOW.
It's a shame that it's not quite as powerful as Lean's ⟨ ⟩
which also functions as a pattern on the LHS, but there probably isn't much we can do about that. I think in the above cases, it would be good to keep the patterns around just to render those more nicely.
Maybe it could be a future AIM project to get such record patterns that can be used for matching as well?
The before/after differences are due to a bug in the |
If #666 is fixed then it still doesn't resolve the problem. In the before picture, the LHS provides quite a lot of information visually, just by being able to line up matching entries on the RHS. This gets lost completely if the LHS is just |
plus changes `Ratify.lagda`: experiments to improve layout of Fig 54 of cardano-ledger.pdf
…ove-superscripts-from-rec-constr
Update re. eliminating constructors on LHS of Here's what the output looks like now that the |
…ove-superscripts-from-rec-constr
- Move open statements to where clauses - Move some open statements to invisible code blocks - Change some alignments
Checklist
CHANGELOG.md