Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some protocol parameters to the security group #660

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Added some protocol parameters to the security group #660

merged 1 commit into from
Jan 31, 2025

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Jan 30, 2025 •
edited
Loading

Description

Previously none of the protocol parameters got assigned to the SecurityGroup, this PR fixes that problem.

see: https://github.com/cardano-foundation/CIPs/blob/master/CIP-1694/README.md?plain=1#L550-L560

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Any semantic changes to the specifications are documented in CHANGELOG.md
  • Code is formatted according to CONTRIBUTING.md
  • Self-reviewed the diff

@Soupstraw Soupstraw marked this pull request as ready for review January 30, 2025 11:33
@carlostome carlostome mentioned this pull request Jan 30, 2025
Draft
23 tasks
WhatisRT
WhatisRT approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@WhatisRT WhatisRT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WhatisRT WhatisRT merged commit 7e0b3c3 into master Jan 31, 2025
8 of 10 checks passed
@WhatisRT WhatisRT deleted the jj/security-group branch January 31, 2025 12:50
github-actions bot added a commit that referenced this pull request Jan 31, 2025
@github-actions
Generate code for GH-660
87d6229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WhatisRT WhatisRT WhatisRT approved these changes

@carlostome carlostome Awaiting requested review from carlostome

@williamdemeo williamdemeo Awaiting requested review from williamdemeo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Soupstraw @WhatisRT