Rename RwdAddr to RewardAddress #985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlostome
approved these changes
Nov 17, 2025
Collaborator
carlostome
left a comment
carlostome
left a comment
There was a problem hiding this comment.
LGTM! I left a few comments about dissaligned figures due to the length of RewardAddress (compared to RwdAddr)
Comment on lines
20
to
23
| indexOfDCert : DCert → List DCert → Maybe Ix | ||
| indexOfRwdAddr : RwdAddr → Withdrawals → Maybe Ix | ||
| indexOfRewardAddress : RewardAddress → Withdrawals → Maybe Ix | ||
| indexOfTxIn : TxIn → ℙ TxIn → Maybe Ix | ||
| indexOfPolicyId : ScriptHash → ℙ ScriptHash → Maybe Ix |
Member
Author
There was a problem hiding this comment.
Yes, and I think this is one of those cases where it even improves readability to align the argument types of the fields, since they're all of the same shape.
Comment on lines
14
to
16
| indexOfDCert : DCert → List DCert → Maybe Ix | ||
| indexOfRwdAddr : RewardAddress → Withdrawals → Maybe Ix | ||
| indexOfRewardAddress : RewardAddress → Withdrawals → Maybe Ix | ||
| indexOfTxIn : TxIn → ℙ TxIn → Maybe Ix |
Member
Author
There was a problem hiding this comment.
Same comment as above (re. aligning argument types as well).
williamdemeo
force-pushed
the
984-change-rwdaddr-to-rewardaddress
branch
from
3aae3ba to
97bf12d
Compare
update CHANGELOG to reflect rename
and improve explanation of well-formedness
williamdemeo
force-pushed
the
984-change-rwdaddr-to-rewardaddress
branch
from
4267565 to
9682a73
Compare
carlostome
added a commit
to IntersectMBO/cardano-ledger
that referenced
this pull request
Nov 19, 2025
This was referenced Nov 19, 2025
lehins
pushed a commit
to IntersectMBO/cardano-ledger
that referenced
this pull request
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes issue #984.
Copilot's Description
This pull request refactors the codebase to rename the type
RwdAddrtoRewardAddressthroughout the project. This change improves clarity and consistency in naming, making it easier to understand the purpose of the type as representing a reward address. The update touches many files across the Haskell, Agda, Markdown, and LaTeX code, ensuring the new name is used everywhere relevant.Type and API Renaming
RwdAddrtoRewardAddressacross all Agda modules, type definitions, and usages, including record fields, function parameters, and map types. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20]Function and Variable Updates
RwdAddr(such astoRwdAddr) to useRewardAddress(such astoRewardAddress). [1] [2] [3] [4]Documentation and Macros
RewardAddressinstead ofRwdAddrfor accuracy and consistency. [1] [2]This change is purely a renaming/refactoring and does not affect the underlying logic or behavior of the code. It should make the codebase clearer for future development and maintenance.
Checklist
CHANGELOG.md