Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the QueryBatchSize field into the BackingStore #1321

Closed
jasagredo opened this issue Nov 22, 2024 · 2 comments
Closed

Move the QueryBatchSize field into the BackingStore #1321

jasagredo opened this issue Nov 22, 2024 · 2 comments
Labels
good first issue Good for newcomers UTxO-HD

Comments

@jasagredo
Copy link
Contributor

          Seems like this would be more appropriate as a field in the `BackingStore` data type instead.

Originally posted by @nfrisby in #1267 (comment)

Perhaps we can remove this field from the LedgerDB top level API and put it into the BackingStore and capture it in the LedgerBackingStoreValueHandle.

Care has to be taken because we adapt the actual number of requested values based on the current diffs in the V1 changelog, so we might not be able to directly remove it from the RangeQuery datatype.

@jasagredo
Copy link
Contributor Author

Also the V2 forker uses Maybe Int while it could also use QueryBatchSize. See #1267 (comment)

@jasagredo
Copy link
Contributor Author

This was implemented in #1304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers UTxO-HD
Projects
None yet
Development

No branches or pull requests

1 participant