UTxO-HD code-review work #1304
Merged
UTxO-HD code-review work #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
requested review from
nfrisby,
amesgen,
fraser-iohk and
dnadales
as code owners
jasagredo
force-pushed
the
utxo-hd-code-review-work
branch
8 times, most recently
from
f4b81e5 to
4fac192
Compare
jasagredo
force-pushed
the
utxo-hd-main
branch
from
c252023 to
34726b9
Compare
nfrisby
reviewed
Dec 9, 2024
| constraints: | ||
| Cabal < 3.13 | ||
| , quickcheck-instances < 0.3.32 | ||
| , data-default < 0.8 |
There was a problem hiding this comment.
Please add a comment explaining that this data-default constraint likely won't be necessary for cardano-ledger-core >1.15.0.0
There was a problem hiding this comment.
(I'm not doing this myself, just because I want to make sure that you didn't add it for some other reason I'm misunderstanding.)
nfrisby
previously requested changes
Dec 9, 2024
ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Ledger/Query.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Ledger/Query.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Ledger/Query.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/ShelleyHFC.hs
Show resolved
Hide resolved
...-consensus-cardano/src/unstable-cardano-testlib/Test/ThreadNet/Infra/ShelleyBasedHardFork.hs
Show resolved
Hide resolved
...boros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/HardFork/Combinator/InjectTxs.hs
Outdated
Show resolved
Hide resolved
...boros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/HardFork/Combinator/InjectTxs.hs
Outdated
Show resolved
Hide resolved
...boros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/HardFork/Combinator/InjectTxs.hs
Outdated
Show resolved
Hide resolved
...boros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/HardFork/Combinator/InjectTxs.hs
Outdated
Show resolved
Hide resolved
...boros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/HardFork/Combinator/InjectTxs.hs
Show resolved
Hide resolved
nfrisby
reviewed
Dec 9, 2024
There was a problem hiding this comment.
I very loosely reviewed the "Reorganize LedgerDB" commit. It had the right shape. Only commented on some non-alphabetical module lists in the cabal files.
Edit: Ah ha... I was reviewing a single commit. GitHub marks my comments as "Outdated"... maybe you alphabetized things in a later commit (... the "formatting" one I'd guess?).
|
I reviewed the two commits explicitly called out in the PR description. The rest were not highlighted, so I'm treating them like PR comments that the PR author addressed and marked as Resolved (from PR 1267). |
jasagredo
force-pushed
the
utxo-hd-code-review-work
branch
from
25bd0c4 to
e0f552d
Compare
|
Committed the requested changes and |
jasagredo
force-pushed
the
utxo-hd-code-review-work
branch
from
e0f552d to
9be3397
Compare
This type for storing resources was reinventing the wheel: `quickcheck-dynamic` already keep track of resources by storing a `Var` for each action result. `IOSim` support for tests is also removed. It would be straightforward to revive `IOSim` support in the future, if necessary.
* Rename `MockState` to `MockMonad`. * Remove exception handler hoop jumping in `mBSClose` and `mBSVHClose`. * Tag `ReadAfterWrite` and `RangeReadAfterWrite` only once per action sequence. * Resolve some TODOs
I had initially decided it was best to replace uses of `ltcollapse` by some new `ltfoldMap` function, but after some thinking it's best to instead use `ltcollapse` as is, but removing the use of monoids there, which currently has no effect. The reason I think this is the right call is because ledger tables are currently a single-constructor newtype, and they will be for at least a while. We do not know what ledger tables will look like when we store more parts of the ledger state, so let's cross that bridge when we get there.
jasagredo
force-pushed
the
utxo-hd-code-review-work
branch
from
9be3397 to
2c5efb4
Compare
9 tasks
nfrisby
approved these changes
Dec 10, 2024
This was referenced Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exists only to accumulate Code-review changes that we will merge into
utxo-hd-mainonce the first review pass is done.There are a couple of commits that are worth considering on their own, namely: