Add ConvertRawTxId, use it for comparing OneEraGenTxIds
#1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amesgen
commented
Mar 25, 2024
Comment on lines
+166
to
+170
| instance ConvertRawTxId (GenTx ByronBlock) where | ||
| toRawTxIdHash (ByronTxId i) = CC.abstractHashToShort i | ||
| toRawTxIdHash (ByronDlgId i) = CC.abstractHashToShort i | ||
| toRawTxIdHash (ByronUpdateProposalId i) = CC.abstractHashToShort i | ||
| toRawTxIdHash (ByronUpdateVoteId i) = CC.abstractHashToShort i |
There was a problem hiding this comment.
This instance assumes that it is not possible for two different constructors to contain the same hash. This seems reasonable, as the payload of these different kinds of transactions are completely different. However, to be extra safe, we could eg prepend a tag byte.
There was a problem hiding this comment.
This seems fine, especially as Byron transactions aren't being newly submitted anymore.
jasagredo
approved these changes
Mar 25, 2024
...-consensus-diffusion/changelog.d/20240325_124036_alexander.esgen_compare_txid_on_raw_hash.md
Outdated
Show resolved
Hide resolved
amesgen
force-pushed
the
amesgen/compare-txid-on-raw-hash
branch
from
883bdb7 to
539c525
Compare
amesgen
force-pushed
the
amesgen/compare-txid-on-raw-hash
branch
from
539c525 to
7ba2a82
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1009