Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate with ouroboros-network-0.14.0.0 #1041

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Integrate with ouroboros-network-0.14.0.0 #1041

merged 1 commit into from
Apr 8, 2024

Conversation

coot
Copy link
Contributor

@coot coot commented Apr 4, 2024 •
edited by amesgen
Loading

Get the public peer selection state variable from Diffusion.Arguments.

@coot coot requested a review from a team as a code owner April 4, 2024 21:29
amesgen
amesgen reviewed Apr 5, 2024
View reviewed changes
Copy link
Member

@amesgen amesgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

  • There is a compilation failure in Test.ThreadNet.Network ATM.
  • The CHaP flake input needs to be bumped.

@coot coot mentioned this pull request Apr 5, 2024
Merged
@coot
Copy link
Contributor Author

coot commented Apr 5, 2024

There's something wrong with GitHub. Upstream branch is at 1edca17, but the UI & actions are showing 32501a4.

@coot
Copy link
Contributor Author

coot commented Apr 5, 2024

There are some degradations: https://www.githubstatus.com/

@coot
ouroboros-consensus-diffusion: PublicPeerSelectionState
b5b71e7 
Get the public peer selection state variable from `Diffusion.Arguments`.
amesgen added a commit that referenced this pull request Apr 8, 2024
@amesgen
PeerSharingAPI fix - backport (#1042)
fd9b8c3 
This PR is a backport of #1041 to `cardano-node-8.9-backports` branch.

- **ouroboros-consensus-diffusion: PublicPeerSelectionState**
- **release ouroboros-consensus-diffusion-0.14.0.0**
@coot coot added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit 2335dc9 Apr 8, 2024
15 checks passed
@coot coot deleted the coot/peerSharingAPI-fix branch April 8, 2024 19:31
@coot coot mentioned this pull request Apr 8, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amesgen amesgen amesgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Ouroboros Network
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coot @amesgen