Add more accurate tracing to LSM #1815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
requested review from
bladyjoker,
dnadales,
fraser-iohk,
geo2a and
nfrisby
as code owners
jasagredo
force-pushed
the
js/more-tracing-lsm
branch
from
169406b to
cbffec9
Compare
jasagredo
force-pushed
the
js/more-tracing-lsm
branch
from
cbffec9 to
c82750a
Compare
bladyjoker
approved these changes
Dec 24, 2025
Contributor
bladyjoker
left a comment
bladyjoker
left a comment
There was a problem hiding this comment.
Not sure how interleaved those events might be, but that might render the whole thing very difficult to work with.
Imagine a scenario where the newLSMLedgerTablesHandle is called concurrently N times, we have no way of matching Rising to Falling edges (bracket matching problem for logs basically).
If these calls or entirely sequential, then the current logging would be sufficient as there'd be no interleaving.
Contributor
Author
|
This is mostly sequential, if not entirely, but this lets us disambiguate whether a deadlock happens in LSM or in Consensus code. |
jasagredo
force-pushed
the
js/more-tracing-lsm
branch
from
c82750a to
9964ec2
Compare
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Consensus Team Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.