CardanoTxOut representation
#951
Conversation
jorisdral
force-pushed
the
jdral/cardano-tx-out
branch
from
7c76c7a to
f8fc59e
Compare
jorisdral
force-pushed
the
jdral/cardano-tx-out
branch
from
f8fc59e to
6f0e42b
Compare
| -- | ||
| -- TODO: can this be removed in favour of EncodeDisk and DecodeDisk? |
There was a problem hiding this comment.
Something to think about
There was a problem hiding this comment.
And probably a good thing to do.
EDIT: actually I'm unsure if we could do this easily. But perhaps can be postponed?
There was a problem hiding this comment.
Let's postpone it
| type family Key l -- TODO: rename to TxIn | ||
|
|
||
| -- | Each @LedgerState@ instance will have the notion of a @Value@ for the | ||
| -- tables. For instance, if we only pulled out only the UTxO set from the ledger | ||
| -- state, this type would be @TxOut@ or @NS TxOut@. | ||
| type Value :: LedgerStateKind -> Type | ||
| type family Value l | ||
| type family Value l -- TODO: rename to TxOut |
There was a problem hiding this comment.
Not a very interesting change, but it is entirely separate from what I've been doing in this PR so let's do it in a new PR
There was a problem hiding this comment.
And actually, is this something we want to change? Are ledgertables UTxO-specific, or would we reuse the same type for other tables like stake-related tables?
There was a problem hiding this comment.
Pff, this is a question I don't have an answer for. I don't know how multiple tables would work. I guess we will have several Value instances indexed by the kind of table? I don't know
| -- TODO: if we make mapkinds of kind @(k1, k2) -> Type@ instead of @k1 -> k2 -> | ||
| -- Type@, then we could reuse most of the @barbies@ machinery. |
There was a problem hiding this comment.
@jasagredo thoughts?
There was a problem hiding this comment.
This sounds very reasonable. I agree with this, but maybe in a follow-up?
|
|
jorisdral
force-pushed
the
jdral/cardano-tx-out
branch
from
b090546 to
e166497
Compare
|
GHA is magically passing now |
...oros-consensus-cardano/src/ouroboros-consensus-cardano/Ouroboros/Consensus/Cardano/Ledger.hs
Show resolved
Hide resolved
...oros-consensus-cardano/src/ouroboros-consensus-cardano/Ouroboros/Consensus/Cardano/Ledger.hs
Show resolved
Hide resolved
Description
Reduce heap size of Cardano
TxOuts by representing them as a flat sum type, instead of anNS