Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that connection manager trace is valid #3465

Closed
coot opened this issue Oct 28, 2021 · 0 comments · Fixed by #3479 or #3532
Closed

Verify that connection manager trace is valid #3465

coot opened this issue Oct 28, 2021 · 0 comments · Fixed by #3479 or #3532
Assignees
@bolt12
Labels
connection-manager Issues / PRs related to connection-manager testing

Comments

@coot
Copy link
Contributor

coot commented Oct 28, 2021 •
edited
Loading

  • the trace should not contain TrUnexpectedlyMissingConnectionState
  • the time between TrConnectionTimeWait and TrConnectionTimeWaitDone should not exceed the configured value (this is related to Verify that connection-manager timeouts are enforced #3330)
  • trace other assertions (like we do with TrUnexpectedlymissingConnectionState and verify that they are do not happen (this way we should be able to detect CAD-3623), for assertions in STM it's enough to turn them into monadic assertions via evaluate (assert p (return ())) and make sure that AssertFailure is a terminating exception.

Nice to have but could be done later:

  • Every inbound or outbound connection is logged with TrIncludeConnection.
  • the trace TrUnregisterConnection is only traced when the connection is the right state.
@coot coot added networking testing connection-manager Issues / PRs related to connection-manager labels Oct 28, 2021
coot added a commit that referenced this issue Oct 29, 2021
@coot
server-test: test connection manager trace
ffeddfa 
Check that `TrUnexpectedlyMissingConnectionState` is not logged.
This is an initial part of #3465.
bolt12 added a commit that referenced this issue Oct 29, 2021
@bolt12
No invalid trace test and monadic assertion error
f84572f 
- This way an assertion is not a pure exception evaluated when printing
an `io-sim` test case, but a simulation error. Note that this will hide
such exceptions from simulation. To test that such assertion do not
happen we can analyse trace.

- Check that `TrUnexpectedlyMissingConnectionState` is not logged.
This is an initial part of #3465.

Authors: Marcin Szamotulski
bolt12 added a commit that referenced this issue Nov 2, 2021
@bolt12
No invalid trace test and monadic assertion error
38fb021 
- This way an assertion is not a pure exception evaluated when printing
an `io-sim` test case, but a simulation error. Note that this will hide
such exceptions from simulation. To test that such assertion do not
happen we can analyse trace.

- Check that `TrUnexpectedlyMissingConnectionState` is not logged.
This is an initial part of #3465.

Authors: Marcin Szamotulski
bolt12 added a commit that referenced this issue Nov 2, 2021
@bolt12
No invalid trace test and monadic assertion error
7809a37 
- This way an assertion is not a pure exception evaluated when printing
an `io-sim` test case, but a simulation error. Note that this will hide
such exceptions from simulation. To test that such assertion do not
happen we can analyse trace.

- Check that `TrUnexpectedlyMissingConnectionState` is not logged.
This is an initial part of #3465.

Authors: Marcin Szamotulski
coot pushed a commit that referenced this issue Nov 5, 2021
@bolt12 @coot
No invalid trace test and monadic assertion error
2272653 
- This way an assertion is not a pure exception evaluated when printing
an `io-sim` test case, but a simulation error. Note that this will hide
such exceptions from simulation. To test that such assertion do not
happen we can analyse trace.

- Check that `TrUnexpectedlyMissingConnectionState` is not logged.
This is an initial part of #3465.

Authors: Marcin Szamotulski
coot pushed a commit that referenced this issue Nov 5, 2021
@bolt12 @coot
No invalid trace test and monadic assertion error
1ce923a 
- This way an assertion is not a pure exception evaluated when printing
an `io-sim` test case, but a simulation error. Note that this will hide
such exceptions from simulation. To test that such assertion do not
happen we can analyse trace.

- Check that `TrUnexpectedlyMissingConnectionState` is not logged.
This is an initial part of #3465.

Authors: Marcin Szamotulski
coot pushed a commit that referenced this issue Nov 5, 2021
@bolt12 @coot
No invalid trace test and monadic assertion error
f95955b 
- This way an assertion is not a pure exception evaluated when printing
an `io-sim` test case, but a simulation error. Note that this will hide
such exceptions from simulation. To test that such assertion do not
happen we can analyse trace.

- Check that `TrUnexpectedlyMissingConnectionState` is not logged.
This is an initial part of #3465.

Authors: Marcin Szamotulski
coot pushed a commit that referenced this issue Nov 11, 2021
@bolt12 @coot
No invalid trace test and monadic assertion error
e89de62 
- This way an assertion is not a pure exception evaluated when printing
an `io-sim` test case, but a simulation error. Note that this will hide
such exceptions from simulation. To test that such assertion do not
happen we can analyse trace.

- Check that `TrUnexpectedlyMissingConnectionState` is not logged.
This is an initial part of #3465.

Authors: Marcin Szamotulski
coot pushed a commit that referenced this issue Nov 15, 2021
@bolt12 @coot
No invalid trace test and monadic assertion error
127fa77 
- This way an assertion is not a pure exception evaluated when printing
an `io-sim` test case, but a simulation error. Note that this will hide
such exceptions from simulation. To test that such assertion do not
happen we can analyse trace.

- Check that `TrUnexpectedlyMissingConnectionState` is not logged.
This is an initial part of #3465.

Authors: Marcin Szamotulski
@bolt12 bolt12 linked a pull request Nov 22, 2021 that will close this issue
Monadify assertions and trace them accordingly #3479
Merged
@bolt12 bolt12 linked a pull request Dec 14, 2021 that will close this issue
Added prop_timeouts_enforced #3532
Merged
@bolt12 bolt12 self-assigned this Jan 25, 2022
@iohk-bors iohk-bors bot closed this as completed in #3532 Feb 3, 2022
@iohk-bors iohk-bors bot moved this to Done in Ouroboros Network Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bolt12 bolt12

Labels
connection-manager Issues / PRs related to connection-manager testing
Projects
None yet
Milestone
No milestone
2 participants
@coot @bolt12