Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #2702

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Update dependencies #2702

merged 2 commits into from
Oct 23, 2020

Conversation

@mrBliss mrBliss added the consensus issues related to ouroboros-consensus label Oct 22, 2020
@mrBliss mrBliss requested a review from edsko October 22, 2020 10:10
, ShelleyBased era
, SL.ApplyBlock era
, SL.GetLedgerView era
, SL.ApplyTx era
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that the ledger has to implement these classes.

BTW, should we move TPraosCrypto to the ledger?

Copy link
Contributor

@edsko edsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed over meet.

The Cardano ThreadNet tests were failing with:

      Exception:
        out of bounds : -5999999999995992
        CallStack (from HasCallStack):
          error, called at src/Shelley/Spec/Ledger/Coin.hs:77:15 in shelley-spec-ledger-0.1.0.0-IHgVjHhhJ1jYZdRhYRAbW:Shelley.Spec.Ledger.Coin

The ledger never permitted negative `Coin`s, but in the last update it has
started checking this when serialising a `Coin`.

We end up with a negative `Coin` because the value of `maxLovelaceSupply` we use
for the Shelley era is `initialLovelacePerCoreNode (= 1000) * #coreNodes`.
However, the Byron ledger state starts out with an initial balance of
6000000000000000, which subtracted from `maxLovelaceSupply`, results in a
negative `Coin`.

Fix this by using an appropriate value for `maxLovelaceSupply` in the Cardano
ThreadNet tests.
@mrBliss mrBliss force-pushed the mrBliss/update-dependencies-20201022 branch from d5fbbf3 to 5afdb40 Compare October 23, 2020 11:01
@mrBliss
Copy link
Contributor Author

mrBliss commented Oct 23, 2020

bors merge

@mrBliss
Copy link
Contributor Author

mrBliss commented Oct 23, 2020

C'mon bors, why do you have to be like this? 🙁

@edsko
Copy link
Contributor

edsko commented Oct 23, 2020

Should I be worried that you're talking to a bot?

@mrBliss
Copy link
Contributor Author

mrBliss commented Oct 23, 2020

Should I be worried that you're talking to a bot?

~You were AFK ... 😄 ~ Oh, you were back already, never mind 🤦

@mrBliss
Copy link
Contributor Author

mrBliss commented Oct 23, 2020

bors ping

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 23, 2020

pong

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Oct 23, 2020

@iohk-bors iohk-bors bot merged commit db30e1f into master Oct 23, 2020
@iohk-bors iohk-bors bot deleted the mrBliss/update-dependencies-20201022 branch October 23, 2020 12:43
mrBliss added a commit to IntersectMBO/cardano-node that referenced this pull request Oct 26, 2020
Highlights:

* A bunch of Shelley types are now parameterised by the crypto instead of the
  era. This means the instantiation changes from `StandardShelley` to
  `StandardCrypto`. See
  IntersectMBO/ouroboros-network#2702

* Because of changes to the era parameterisation in the ledger, one should now
  use `ShelleyBasedEra` (from `Ouroboros.Consensus.Shelley.Eras`) as the
  constraint on `era` instead of `Era`. With the former you will be able to
  derive many more constraints.

* Consensus supports a bunch of new queries:
  + `GetGenesisConfig`: return the (compacted) genesis config used by the node.
  + `DebugNewEpochState`: `cardano-node` now uses this when querying the ledger
    state, contains slightly more information than the former
    `GetCurrentEpochState`.
  + `DebugEpochState`: the former `GetCurrentEpochState`.
  + `DebugChainDepState`: contains the epoch nonces, etc.
  + `GetCurrentEra`: use
    ```haskell
    eraIndexToInt :: EraIndex xs -> Int
    ```
    on its result to get the current era as index starting from 0.

  Note that some of these queries require a new network version. You don't have
  to do anything for this. You will only notice this when submitting one of the
  new queries to an older node that doesn't support it; you'll get a
  `ShelleyEncoderUnsupportedQuery` exception. Better to get such an exception
  when submitting the unsupported query than getting no response at all because
  the receiver fails to decode the request.

  See IntersectMBO/ouroboros-network#2694 for more
  details.
mrBliss added a commit to IntersectMBO/cardano-node that referenced this pull request Oct 26, 2020
Highlights:

* A bunch of Shelley types are now parameterised by the crypto instead of the
  era. This means the instantiation changes from `StandardShelley` to
  `StandardCrypto`. See
  IntersectMBO/ouroboros-network#2702

* Because of changes to the era parameterisation in the ledger, one should now
  use `ShelleyBasedEra` (from `Ouroboros.Consensus.Shelley.Eras`) as the
  constraint on `era` instead of `Era`. With the former you will be able to
  derive many more constraints.

* Consensus supports a bunch of new queries:
  + `GetGenesisConfig`: return the (compacted) genesis config used by the node.
  + `DebugEpochState`: was previously called `GetCurrentEpochState`.
  + `DebugNewEpochState`: this contains slightly more information than the former
    `DebugEpochState`. NOTE: this is not currently used yet, but the goal is to
    use this when querying the ledger state.
  + `DebugChainDepState`: contains the epoch nonces, etc.
  + `GetCurrentEra`: use
    ```haskell
    eraIndexToInt :: EraIndex xs -> Int
    ```
    on its result to get the current era as index starting from 0.

  Note that some of these queries require a new network version. You don't have
  to do anything for this. You will only notice this when submitting one of the
  new queries to an older node that doesn't support it; you'll get a
  `ShelleyEncoderUnsupportedQuery` exception. Better to get such an exception
  when submitting the unsupported query than getting no response at all because
  the receiver fails to decode the request.

  See IntersectMBO/ouroboros-network#2694 for more
  details.
mrBliss added a commit to IntersectMBO/cardano-node that referenced this pull request Oct 26, 2020
Highlights:

* A bunch of Shelley types are now parameterised by the crypto instead of the
  era. This means the instantiation changes from `StandardShelley` to
  `StandardCrypto`. See
  IntersectMBO/ouroboros-network#2702

* Because of changes to the era parameterisation in the ledger, one should now
  use `ShelleyBasedEra` (from `Ouroboros.Consensus.Shelley.Eras`) as the
  constraint on `era` instead of `Era`. With the former you will be able to
  derive many more constraints.

* Consensus supports a bunch of new queries:
  + `GetGenesisConfig`: return the (compacted) genesis config used by the node.
  + `DebugEpochState`: was previously called `GetCurrentEpochState`.
  + `DebugNewEpochState`: this contains slightly more information than the
    former `DebugEpochState`. NOTE: this is not currently used yet, but the goal
    is to use this when querying the ledger state.
  + `DebugChainDepState`: contains the epoch nonces, etc.
  + `GetCurrentEra`: use
    ```haskell
    eraIndexToInt :: EraIndex xs -> Int
    ```
    on its result to get the current era as index starting from 0.

  Note that some of these queries require a new network version. You don't have
  to do anything for this. You will only notice this when submitting one of the
  new queries to an older node that doesn't support it; you'll get a
  `ShelleyEncoderUnsupportedQuery` exception. Better to get such an exception
  when submitting the unsupported query than getting no response at all because
  the receiver fails to decode the request.

  See IntersectMBO/ouroboros-network#2694 for more
  details.
intricate pushed a commit to IntersectMBO/cardano-node that referenced this pull request Oct 27, 2020
Highlights:

* A bunch of Shelley types are now parameterised by the crypto instead of the
  era. This means the instantiation changes from `StandardShelley` to
  `StandardCrypto`. See
  IntersectMBO/ouroboros-network#2702

* Because of changes to the era parameterisation in the ledger, one should now
  use `ShelleyBasedEra` (from `Ouroboros.Consensus.Shelley.Eras`) as the
  constraint on `era` instead of `Era`. With the former you will be able to
  derive many more constraints.

* Consensus supports a bunch of new queries:
  + `GetGenesisConfig`: return the (compacted) genesis config used by the node.
  + `DebugEpochState`: was previously called `GetCurrentEpochState`.
  + `DebugNewEpochState`: this contains slightly more information than the
    former `DebugEpochState`. NOTE: this is not currently used yet, but the goal
    is to use this when querying the ledger state.
  + `DebugChainDepState`: contains the epoch nonces, etc.
  + `GetCurrentEra`: use
    ```haskell
    eraIndexToInt :: EraIndex xs -> Int
    ```
    on its result to get the current era as index starting from 0.

  Note that some of these queries require a new network version. You don't have
  to do anything for this. You will only notice this when submitting one of the
  new queries to an older node that doesn't support it; you'll get a
  `ShelleyEncoderUnsupportedQuery` exception. Better to get such an exception
  when submitting the unsupported query than getting no response at all because
  the receiver fails to decode the request.

  See IntersectMBO/ouroboros-network#2694 for more
  details.
intricate pushed a commit to IntersectMBO/cardano-node that referenced this pull request Oct 27, 2020
Highlights:

* A bunch of Shelley types are now parameterised by the crypto instead of the
  era. This means the instantiation changes from `StandardShelley` to
  `StandardCrypto`. See
  IntersectMBO/ouroboros-network#2702

* Because of changes to the era parameterisation in the ledger, one should now
  use `ShelleyBasedEra` (from `Ouroboros.Consensus.Shelley.Eras`) as the
  constraint on `era` instead of `Era`. With the former you will be able to
  derive many more constraints.

* Consensus supports a bunch of new queries:
  + `GetGenesisConfig`: return the (compacted) genesis config used by the node.
  + `DebugEpochState`: was previously called `GetCurrentEpochState`.
  + `DebugNewEpochState`: this contains slightly more information than the
    former `DebugEpochState`. NOTE: this is not currently used yet, but the goal
    is to use this when querying the ledger state.
  + `DebugChainDepState`: contains the epoch nonces, etc.
  + `GetCurrentEra`: use
    ```haskell
    eraIndexToInt :: EraIndex xs -> Int
    ```
    on its result to get the current era as index starting from 0.

  Note that some of these queries require a new network version. You don't have
  to do anything for this. You will only notice this when submitting one of the
  new queries to an older node that doesn't support it; you'll get a
  `ShelleyEncoderUnsupportedQuery` exception. Better to get such an exception
  when submitting the unsupported query than getting no response at all because
  the receiver fails to decode the request.

  See IntersectMBO/ouroboros-network#2694 for more
  details.
intricate added a commit to IntersectMBO/cardano-node that referenced this pull request Oct 27, 2020
Highlights:

* A bunch of Shelley types are now parameterised by the crypto instead of the
  era. This means the instantiation changes from `StandardShelley` to
  `StandardCrypto`. See
  IntersectMBO/ouroboros-network#2702

* Because of changes to the era parameterisation in the ledger, one should now
  use `ShelleyBasedEra` (from `Ouroboros.Consensus.Shelley.Eras`) as the
  constraint on `era` instead of `Era`. With the former you will be able to
  derive many more constraints.

* Consensus supports a bunch of new queries:
  + `GetGenesisConfig`: return the (compacted) genesis config used by the node.
  + `DebugEpochState`: was previously called `GetCurrentEpochState`.
  + `DebugNewEpochState`: this contains slightly more information than the
    former `DebugEpochState`. NOTE: this is not currently used yet, but the goal
    is to use this when querying the ledger state.
  + `DebugChainDepState`: contains the epoch nonces, etc.
  + `GetCurrentEra`: use
    ```haskell
    eraIndexToInt :: EraIndex xs -> Int
    ```
    on its result to get the current era as index starting from 0.

  Note that some of these queries require a new network version. You don't have
  to do anything for this. You will only notice this when submitting one of the
  new queries to an older node that doesn't support it; you'll get a
  `ShelleyEncoderUnsupportedQuery` exception. Better to get such an exception
  when submitting the unsupported query than getting no response at all because
  the receiver fails to decode the request.

  See IntersectMBO/ouroboros-network#2694 for more
  details.

Co-authored-by: Luke Nadur <19835357+intricate@users.noreply.github.com>
Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
intricate added a commit to IntersectMBO/cardano-node that referenced this pull request Oct 27, 2020
Highlights:

* A bunch of Shelley types are now parameterised by the crypto instead of the
  era. This means the instantiation changes from `StandardShelley` to
  `StandardCrypto`. See
  IntersectMBO/ouroboros-network#2702

* Because of changes to the era parameterisation in the ledger, one should now
  use `ShelleyBasedEra` (from `Ouroboros.Consensus.Shelley.Eras`) as the
  constraint on `era` instead of `Era`. With the former you will be able to
  derive many more constraints.

* Consensus supports a bunch of new queries:
  + `GetGenesisConfig`: return the (compacted) genesis config used by the node.
  + `DebugEpochState`: was previously called `GetCurrentEpochState`.
  + `DebugNewEpochState`: this contains slightly more information than the
    former `DebugEpochState`. NOTE: this is not currently used yet, but the goal
    is to use this when querying the ledger state.
  + `DebugChainDepState`: contains the epoch nonces, etc.
  + `GetCurrentEra`: use
    ```haskell
    eraIndexToInt :: EraIndex xs -> Int
    ```
    on its result to get the current era as index starting from 0.

  Note that some of these queries require a new network version. You don't have
  to do anything for this. You will only notice this when submitting one of the
  new queries to an older node that doesn't support it; you'll get a
  `ShelleyEncoderUnsupportedQuery` exception. Better to get such an exception
  when submitting the unsupported query than getting no response at all because
  the receiver fails to decode the request.

  See IntersectMBO/ouroboros-network#2694 for more
  details.

Co-authored-by: Luke Nadur <19835357+intricate@users.noreply.github.com>
Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
iohk-bors bot added a commit to IntersectMBO/cardano-node that referenced this pull request Oct 28, 2020
2019: Update dependencies r=mrBliss a=mrBliss

Highlights:

* A bunch of Shelley types are now parameterised by the crypto instead of the
  era. This means the instantiation changes from `StandardShelley` to
  `StandardCrypto`. See IntersectMBO/ouroboros-network#2702

* Because of changes to the era parameterisation in the ledger, one should now
  use `ShelleyBasedEra` (from `Ouroboros.Consensus.Shelley.Eras`) as the
  constraint on `era` instead of `Era`. With the former you will be able to
  derive many more constraints.

* Consensus supports a bunch of new queries:
  + `GetGenesisConfig`: return the (compacted) genesis config used by the node.
  + `DebugEpochState`: was previously called `GetCurrentEpochState`.
  + `DebugNewEpochState`: this contains slightly more information than the
    former `DebugEpochState`. NOTE: in the second commit we start using this to
    query the ledger state.
  + `DebugChainDepState`: contains the epoch nonces, etc.
  + `GetCurrentEra`: use
    ```haskell
    eraIndexToInt :: EraIndex xs -> Int
    ```
    on its result to get the current era as index starting from 0.

  Note that some of these queries require a new network version. You don't have
  to do anything for this. You will only notice this when submitting one of the
  new queries to an older node that doesn't support it; you'll get a
  `ShelleyEncoderUnsupportedQuery` exception. Better to get such an exception
  when submitting the unsupported query than getting no response at all because
  the receiver fails to decode the request.

  See IntersectMBO/ouroboros-network#2694 for more details.

Co-authored-by: Thomas Winant <thomas@well-typed.com>
Co-authored-by: Luke Nadur <19835357+intricate@users.noreply.github.com>
iohk-bors bot added a commit to IntersectMBO/cardano-node that referenced this pull request Oct 28, 2020
2019: Update dependencies r=mrBliss a=mrBliss

Highlights:

* A bunch of Shelley types are now parameterised by the crypto instead of the
  era. This means the instantiation changes from `StandardShelley` to
  `StandardCrypto`. See IntersectMBO/ouroboros-network#2702

* Because of changes to the era parameterisation in the ledger, one should now
  use `ShelleyBasedEra` (from `Ouroboros.Consensus.Shelley.Eras`) as the
  constraint on `era` instead of `Era`. With the former you will be able to
  derive many more constraints.

* Consensus supports a bunch of new queries:
  + `GetGenesisConfig`: return the (compacted) genesis config used by the node.
  + `DebugEpochState`: was previously called `GetCurrentEpochState`.
  + `DebugNewEpochState`: this contains slightly more information than the
    former `DebugEpochState`. NOTE: in the second commit we start using this to
    query the ledger state.
  + `DebugChainDepState`: contains the epoch nonces, etc.
  + `GetCurrentEra`: use
    ```haskell
    eraIndexToInt :: EraIndex xs -> Int
    ```
    on its result to get the current era as index starting from 0.

  Note that some of these queries require a new network version. You don't have
  to do anything for this. You will only notice this when submitting one of the
  new queries to an older node that doesn't support it; you'll get a
  `ShelleyEncoderUnsupportedQuery` exception. Better to get such an exception
  when submitting the unsupported query than getting no response at all because
  the receiver fails to decode the request.

  See IntersectMBO/ouroboros-network#2694 for more details.

Co-authored-by: Thomas Winant <thomas@well-typed.com>
Co-authored-by: Luke Nadur <19835357+intricate@users.noreply.github.com>
iohk-bors bot added a commit to IntersectMBO/cardano-node that referenced this pull request Oct 28, 2020
2019: Update dependencies r=mrBliss a=mrBliss

Highlights:

* A bunch of Shelley types are now parameterised by the crypto instead of the
  era. This means the instantiation changes from `StandardShelley` to
  `StandardCrypto`. See IntersectMBO/ouroboros-network#2702

* Because of changes to the era parameterisation in the ledger, one should now
  use `ShelleyBasedEra` (from `Ouroboros.Consensus.Shelley.Eras`) as the
  constraint on `era` instead of `Era`. With the former you will be able to
  derive many more constraints.

* Consensus supports a bunch of new queries:
  + `GetGenesisConfig`: return the (compacted) genesis config used by the node.
  + `DebugEpochState`: was previously called `GetCurrentEpochState`.
  + `DebugNewEpochState`: this contains slightly more information than the
    former `DebugEpochState`. NOTE: in the second commit we start using this to
    query the ledger state.
  + `DebugChainDepState`: contains the epoch nonces, etc.
  + `GetCurrentEra`: use
    ```haskell
    eraIndexToInt :: EraIndex xs -> Int
    ```
    on its result to get the current era as index starting from 0.

  Note that some of these queries require a new network version. You don't have
  to do anything for this. You will only notice this when submitting one of the
  new queries to an older node that doesn't support it; you'll get a
  `ShelleyEncoderUnsupportedQuery` exception. Better to get such an exception
  when submitting the unsupported query than getting no response at all because
  the receiver fails to decode the request.

  See IntersectMBO/ouroboros-network#2694 for more details.

Co-authored-by: Thomas Winant <thomas@well-typed.com>
Co-authored-by: Luke Nadur <19835357+intricate@users.noreply.github.com>
JaredCorduan pushed a commit to IntersectMBO/cardano-node that referenced this pull request Nov 3, 2020
Highlights:

* A bunch of Shelley types are now parameterised by the crypto instead of the
  era. This means the instantiation changes from `StandardShelley` to
  `StandardCrypto`. See
  IntersectMBO/ouroboros-network#2702

* Because of changes to the era parameterisation in the ledger, one should now
  use `ShelleyBasedEra` (from `Ouroboros.Consensus.Shelley.Eras`) as the
  constraint on `era` instead of `Era`. With the former you will be able to
  derive many more constraints.

* Consensus supports a bunch of new queries:
  + `GetGenesisConfig`: return the (compacted) genesis config used by the node.
  + `DebugEpochState`: was previously called `GetCurrentEpochState`.
  + `DebugNewEpochState`: this contains slightly more information than the
    former `DebugEpochState`. NOTE: this is not currently used yet, but the goal
    is to use this when querying the ledger state.
  + `DebugChainDepState`: contains the epoch nonces, etc.
  + `GetCurrentEra`: use
    ```haskell
    eraIndexToInt :: EraIndex xs -> Int
    ```
    on its result to get the current era as index starting from 0.

  Note that some of these queries require a new network version. You don't have
  to do anything for this. You will only notice this when submitting one of the
  new queries to an older node that doesn't support it; you'll get a
  `ShelleyEncoderUnsupportedQuery` exception. Better to get such an exception
  when submitting the unsupported query than getting no response at all because
  the receiver fails to decode the request.

  See IntersectMBO/ouroboros-network#2694 for more
  details.

Co-authored-by: Luke Nadur <19835357+intricate@users.noreply.github.com>
Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
newhoggy pushed a commit to IntersectMBO/cardano-api that referenced this pull request May 23, 2023
Highlights:

* A bunch of Shelley types are now parameterised by the crypto instead of the
  era. This means the instantiation changes from `StandardShelley` to
  `StandardCrypto`. See
  IntersectMBO/ouroboros-network#2702

* Because of changes to the era parameterisation in the ledger, one should now
  use `ShelleyBasedEra` (from `Ouroboros.Consensus.Shelley.Eras`) as the
  constraint on `era` instead of `Era`. With the former you will be able to
  derive many more constraints.

* Consensus supports a bunch of new queries:
  + `GetGenesisConfig`: return the (compacted) genesis config used by the node.
  + `DebugEpochState`: was previously called `GetCurrentEpochState`.
  + `DebugNewEpochState`: this contains slightly more information than the
    former `DebugEpochState`. NOTE: this is not currently used yet, but the goal
    is to use this when querying the ledger state.
  + `DebugChainDepState`: contains the epoch nonces, etc.
  + `GetCurrentEra`: use
    ```haskell
    eraIndexToInt :: EraIndex xs -> Int
    ```
    on its result to get the current era as index starting from 0.

  Note that some of these queries require a new network version. You don't have
  to do anything for this. You will only notice this when submitting one of the
  new queries to an older node that doesn't support it; you'll get a
  `ShelleyEncoderUnsupportedQuery` exception. Better to get such an exception
  when submitting the unsupported query than getting no response at all because
  the receiver fails to decode the request.

  See IntersectMBO/ouroboros-network#2694 for more
  details.

Co-authored-by: Luke Nadur <19835357+intricate@users.noreply.github.com>
Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
newhoggy pushed a commit to IntersectMBO/cardano-cli that referenced this pull request May 24, 2023
Highlights:

* A bunch of Shelley types are now parameterised by the crypto instead of the
  era. This means the instantiation changes from `StandardShelley` to
  `StandardCrypto`. See
  IntersectMBO/ouroboros-network#2702

* Because of changes to the era parameterisation in the ledger, one should now
  use `ShelleyBasedEra` (from `Ouroboros.Consensus.Shelley.Eras`) as the
  constraint on `era` instead of `Era`. With the former you will be able to
  derive many more constraints.

* Consensus supports a bunch of new queries:
  + `GetGenesisConfig`: return the (compacted) genesis config used by the node.
  + `DebugEpochState`: was previously called `GetCurrentEpochState`.
  + `DebugNewEpochState`: this contains slightly more information than the
    former `DebugEpochState`. NOTE: this is not currently used yet, but the goal
    is to use this when querying the ledger state.
  + `DebugChainDepState`: contains the epoch nonces, etc.
  + `GetCurrentEra`: use
    ```haskell
    eraIndexToInt :: EraIndex xs -> Int
    ```
    on its result to get the current era as index starting from 0.

  Note that some of these queries require a new network version. You don't have
  to do anything for this. You will only notice this when submitting one of the
  new queries to an older node that doesn't support it; you'll get a
  `ShelleyEncoderUnsupportedQuery` exception. Better to get such an exception
  when submitting the unsupported query than getting no response at all because
  the receiver fails to decode the request.

  See IntersectMBO/ouroboros-network#2694 for more
  details.

Co-authored-by: Luke Nadur <19835357+intricate@users.noreply.github.com>
Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus issues related to ouroboros-consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants