Make PeerCooling more robust #4748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Outbound Governor might not see `PeerCooling`: * since STM doesn't guarantee that every update is visible. `asyncDemotion` has to be robust enough to accept that `PeerCold` without seeing `PeerCooling` before; * or there was an error while demoting a hot peer, in which we transition to `PeerCold` directly.
Carefully update the state to `PeerCooling` so that we don't overwrite `PeerCold`.
karknu
added a commit
to karknu/cardano-node
that referenced
this pull request
Dec 13, 2023
Includes fix in IntersectMBO/ouroboros-network#4748
bolt12
approved these changes
Dec 14, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug which causes the outbound governor to loose track of an outbound connection. This can prevent outbound governor to notice a demotion, and thus prevent it to re-establish a connection. This can happen only in specific conditions, with rather low frequency, however high enough to be observed by some SPOs.
outbound-governor: made asyncDemotion recognition more robust
The Outbound Governor might not see
PeerCoolingstate, sinceSTMdoesn't guarantee that every update is visible.asyncDemotionhas to be robust enough to acceptPeerColdwithout seeingPeerCoolingbefore.peer-state-actions: made closePeerConnection more robust
Carefully update the state to
PeerCoolingso that we don't overwritePeerCold, refChecklist