Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ping updates #4819

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Ping updates #4819

merged 3 commits into from
Mar 4, 2024

Conversation

karknu
Copy link
Contributor

@karknu karknu commented Mar 1, 2024 •
edited
Loading

Description

Add support for NodeToNodeVersion13.
Add support for decoding peersharing support.

Partially fixes #4818 by adding support for V13.

Checklist

  • Branch
    • Updated changelog files.
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • New tests are added if needed and existing tests are updated
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@karknu
NodeToNodeVersionV13 support
8c58412
@karknu
Discover peersharing support
1cf67cd 
Add ability to discover if the other side support peersharing.
@karknu
update changelog
62b24f8
@karknu karknu marked this pull request as ready for review March 1, 2024 11:02
@karknu karknu requested a review from coot as a code owner March 1, 2024 11:02
@coot coot added the cardano-ping Iessues / PRs related to cardano-ping label Mar 4, 2024
coot
coot approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karknu karknu added this pull request to the merge queue Mar 4, 2024
Merged via the queue into master with commit 335c186 Mar 4, 2024
13 checks passed
@karknu karknu deleted the karknu/ping_update branch March 4, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot approved these changes

Assignees

@karknu karknu

Labels
cardano-ping Iessues / PRs related to cardano-ping
Projects
Ouroboros Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cardano-ping crashes when encountering unknown versions
2 participants
@karknu @coot