Typed Protocols: new API #4935
Merged
Typed Protocols: new API #4935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
force-pushed
the
coot/typed-protocols-new-api
branch
3 times, most recently
from
4b8c1f7
to
f270fd5
Compare
coot
force-pushed
the
coot/typed-protocols-new-api
branch
from
f270fd5
to
4242d6d
Compare
coot
force-pushed
the
coot/typed-protocols-new-api
branch
from
4242d6d
to
d295ced
Compare
|
Not related to the PR directly but I guess we could sneak it here, there's a usage binding in the module chain-sync that is not referenced anywhere - maybe we can remove it completely? |
coot
force-pushed
the
coot/typed-protocols-new-api
branch
3 times, most recently
from
f2cf734
to
2b81820
Compare
Which one? |
coot
force-pushed
the
coot/typed-protocols-new-api
branch
from
2b81820
to
234f3fc
Compare
It's this one: https://github.com/IntersectMBO/ouroboros-network/blob/coot/tx-submission/ouroboros-network/demo/chain-sync.hs#L191-L194 |
coot
force-pushed
the
coot/typed-protocols-new-api
branch
3 times, most recently
from
8f7be2d
to
7d73076
Compare
coot
force-pushed
the
coot/typed-protocols-new-api
branch
from
7d73076
to
babfabf
Compare
coot
force-pushed
the
coot/typed-protocols-new-api
branch
2 times, most recently
from
1f7109a
to
240cf23
Compare
Most part of this patch is updating dependencies.
This is only useful for debugging a failing test case.
We use pipelined client, hence we need to use an buffered channel.
The client side of each block-fetch protocol has to run until it's completion, otherwise it might happen that we will not generate a trace which marks completion of fetching all blocks in a batch (`CompletedFetchBatch`). This results in failure of `tracePropertyInFlight`.
The first assertion of `fetchDecisionsForStateSnapshot` was triggered. We need first kill the fetch thread before the client side terminates.
This is useful API for running stateful peers.
ProtocolTimeLimits can be a newtype.
Allow to build against nothunks-0.1; `ouroboros-consensus` and `plutus-core` do not yet use `nothunks-0.2`.
This ought to be part of the PR which introduced `NumTxIdsToAck`.
typed-protocols-0.3.0.0 provide better stateful API, which allows us to decouple `Message` type from it encoding. This is used to remove `query resesult` field of `MsgResp` of the `LocalStateQuery` mini-protocol.
coot
force-pushed
the
coot/typed-protocols-new-api
branch
from
0adc34b
to
e66922b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using input-output-hk/typed-protocols#52 & input-output-hk/typed-protocols#61.
TODO:
cabal.projectonce New API for typed-protocols input-output-hk/typed-protocols#52 is published.Performance
No performance regression was found when running the benchmarking cluster using
cardano-node-9.1.0as a base. No regression was found when syncing mainnet.Checklist
Quality
Maintenance
ouroboros-networkproject.