Skip to content

Improved network-mux haddocks #5182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2025
Merged

Improved network-mux haddocks #5182

merged 1 commit into from
Aug 7, 2025

Conversation

@coot
Copy link
Collaborator

@coot coot commented Aug 7, 2025 •
edited
Loading

Description

To expose haddocks attached to arguments of MakeBearer callback,
a type alias is exposed.

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@coot
network-mux: haddock improvements
853011b 
To expose haddocks attached to arguments of `MakeBearer` callback,
a type alias is exposed.
@coot coot requested a review from a team as a code owner August 7, 2025 09:52
@github-project-automation github-project-automation bot moved this to In Progress in Ouroboros Network Aug 7, 2025
@coot coot added the mux issues related to network-mux label Aug 7, 2025
@coot coot self-assigned this Aug 7, 2025
@coot coot added the documentation Network Documentation related tasks label Aug 7, 2025
@coot coot moved this from In Progress to In Review in Ouroboros Network Aug 7, 2025
@coot coot enabled auto-merge August 7, 2025 10:07
@coot coot added this pull request to the merge queue Aug 7, 2025
Merged via the queue into main with commit 113d308 Aug 7, 2025
13 checks passed
@coot coot deleted the coot/network-mux-haddocks branch August 7, 2025 10:46
@github-project-automation github-project-automation bot moved this from In Review to Done in Ouroboros Network Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crocodile-dentist crocodile-dentist crocodile-dentist approved these changes

Assignees

@coot coot

Labels

documentation Network Documentation related tasks mux issues related to network-mux

Projects

Ouroboros Network
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coot @crocodile-dentist