This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
#1078 Use correct envelope type when decoding it #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbolymer
commented
May 30, 2023
| [ FromCDDLTx "Witnessed Tx AlonzoEra" CddlTx | ||
| , FromCDDLTx "Unwitnessed Tx AlonzoEra" CddlTx | ||
| , FromCDDLTx "Witnessed Tx BabbageEra" CddlTx | ||
| , FromCDDLTx "Unwitnessed Tx BabbageEra" CddlTx |
There was a problem hiding this comment.
What other types can we expect here?
newhoggy
approved these changes
May 30, 2023
Jimbo4350
reviewed
May 31, 2023
| @@ -188,6 +188,9 @@ seqToList :: Seq.StrictSeq a -> [a] | |||
| seqToList (x Seq.:<| rest) = x : seqToList rest | |||
| seqToList Seq.Empty = [] | |||
|
|
|||
| newtype CddlTx = CddlTx { unCddlTx :: InAnyCardanoEra Tx } | |||
There was a problem hiding this comment.
Why duplicate this type?
There was a problem hiding this comment.
It has a single use case across our repos - to use it as a wrapper in FromCDDLTx. It's not exported from here so it's not usable outside of this module. It seemed easier to just copy it rather than add it to cardano-api and expose it from there.
There was a problem hiding this comment.
@Jimbo4350 Is it fine for you? If yes, I'll be happy to merge it.
Jimbo4350
approved these changes
Aug 14, 2023
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1078 by using different
TextEnvelopeTypewhen deserializing text envelope.Repro in
cardan-api: IntersectMBO/cardano-api#29cc: @newhoggy @Jimbo4350
Pre-submit checklist: