Fix missing datums for toCardanoTxBody

[anton-k]

Fixes #139

[anton-k]

Maybe the same thing should be applied to cardano-api, since the fix in the code that was copied from that repo,
if you can investiagate it I can provide the fix for cardano-api either.

[sjoerdvisscher]

@anton-k The change has already been applied after we copied it! https://github.com/input-output-hk/cardano-node/blob/master/cardano-api/src/Cardano/Api/TxBody.hs#L2600

It looks like your nub is not necessary.

[sjoerdvisscher]

Isn't this the same as toCardanoScriptData?

[anton-k]

Indeed, I've fixed that

[anton-k]

@anton-k The change has already been applied after we copied it! https://github.com/input-output-hk/cardano-node/blob/master/cardano-api/src/Cardano/Api/TxBody.hs#L2600

It looks like your nub is not necessary.

We need nub in case if we have several inputs with the same script, otherwise witness is going to be duplicated.
Also outputs can contain several datums which are the same.

[sjoerdvisscher]

Thanks!

[anton-k]

@sjoerdvisscher Thanks for merging!
It will be also cool to add nub to cardano-api version of it. In our project we had to create our own makeTransactionBody just for that reason. we had case where there are many inputs that are guarded by the same script and lead to duplication of the data and bloat in TX-size

[sjoerdvisscher]

@anton-k I agree, could you open an issue (or PR) against cardano-node?