Skip to content

Commit

Permalink
Fix haddock dropdown element in haddock index (#6556)
Browse files Browse the repository at this point in the history
  • Loading branch information
zeme-wana authored Oct 10, 2024
1 parent 719bd73 commit c217c3b
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 8 deletions.
19 changes: 14 additions & 5 deletions .github/workflows/haddock-site.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ on:
inputs:
ref:
description: |
The $ref to build off of, e.g. "1.29.0.0", "master", or any other valid git ref.
The ref to build off of, e.g. "1.29.0.0", "master", or any other valid git ref.
When making a release, this is usually the version tag, e.g. "1.29.0.0", and will be
equal to the $destination input below. When back-porting this could be a commit sha instead.
required: true
type: string

destination:
description: |
The $destination folder, e.g. when "1.29.0.0" the haddock site will be deployed to:
The destination folder, e.g. when "1.29.0.0" the haddock site will be deployed to:
https://plutus.cardano.intersectmbo.org/haddock/1.29.0.0
required: true
type: string
Expand All @@ -33,11 +33,20 @@ on:
description: |
If true, then the haddock site will also be deployed to:
https://plutus.cardano.intersectmbo.org/haddock/latest.
You want to leave this to true unless you are deploying old versions or back-porting.
You want to check this when you are making a release.
You want to uncheck this when you are deploying old versions or back-porting.
type: boolean
required: true
default: true

script_ref:
description: |
What branch to fetch the combined-haddock.sh script from.
Leave this to 'master' unless you are testing a new version of the script.
type: string
required: true
default: 'master'

jobs:
deploy:
name: Deploy
Expand All @@ -54,8 +63,8 @@ jobs:

- name: Checkout Haddock Script
run: |
git fetch origin master
git checkout origin/master ./scripts/combined-haddock.sh
git fetch origin ${{ inputs.script_ref }}
git checkout origin/${{ inputs.script_ref }} ./scripts/combined-haddock.sh
- name: Build Site
run: |
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ node.sock
.pre-commit-config.yaml
secrets/*/.gpg-id
ghcid.txt
haddock
haddock*
.private
linkchecker-out.txt
plutus-pab/test-node/testnet/db
Expand Down
7 changes: 5 additions & 2 deletions scripts/combined-haddock.sh
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,9 @@ fi
echo "Injecting additional prologue html"

list-valid-plutus-versions() {
git fetch --tags --force
local versions="$(git tag | grep -Eo '[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+' | sort -rV | uniq | tr ' ' '\n')"
local min_ver="1.27.0.0"
local min_ver="1.30.0.0"
echo master
echo latest
for ver in $versions; do
Expand Down Expand Up @@ -272,7 +273,9 @@ build-version-select-html() {
echo "$html"
}

inject-text-at-char "$OUTPUT_DIR/index.html" 1465 "$(build-version-select-html)"
SELECT_ELEM_POSITION_IN_INDEX_HTML=1465

inject-text-at-char "$OUTPUT_DIR/index.html" $SELECT_ELEM_POSITION_IN_INDEX_HTML "$(build-version-select-html)"



Expand Down

1 comment on commit c217c3b

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Plutus Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite Current: c217c3b Previous: 719bd73 Ratio
validation-auction_2-5 272.9 μs 242.4 μs 1.13
validation-ping-pong-1 469.5 μs 447.1 μs 1.05
validation-ping-pong-2 470.3 μs 390.8 μs 1.20
validation-stablecoin_1-3 1490 μs 1398 μs 1.07
validation-uniswap-1 593.5 μs 416.5 μs 1.42
validation-uniswap-2 315.9 μs 220.3 μs 1.43
validation-uniswap-3 2490 μs 1752 μs 1.42
validation-uniswap-4 478.1 μs 335 μs 1.43
validation-uniswap-5 1637 μs 1154 μs 1.42
validation-uniswap-6 456.9 μs 319.7 μs 1.43
validation-vesting-1 500.2 μs 351.7 μs 1.42
validation-decode-stablecoin_2-2 182.5 μs 162.4 μs 1.12
validation-decode-stablecoin_2-3 1064 μs 844.4 μs 1.26
validation-decode-uniswap-2 327.9 μs 306.7 μs 1.07
validation-decode-uniswap-3 1032 μs 719.8 μs 1.43
validation-decode-uniswap-4 253.8 μs 178.3 μs 1.42
validation-decode-uniswap-5 1029 μs 720 μs 1.43
validation-decode-uniswap-6 254.6 μs 194.1 μs 1.31
nofib-primetest/50digits 147600 μs 127400 μs 1.16
nofib-queens4x4/bt 7599 μs 5328 μs 1.43
nofib-queens4x4/bm 9639 μs 6796 μs 1.42
nofib-queens4x4/bjbt1 9222 μs 6509 μs 1.42
nofib-queens4x4/bjbt2 8650 μs 6098 μs 1.42
nofib-queens4x4/fc 14910 μs 13850 μs 1.08
nofib-queens5x5/bt 88310 μs 72920 μs 1.21
nofib-queens5x5/bm 85330 μs 77890 μs 1.10
nofib-queens5x5/bjbt1 121300 μs 85630 μs 1.42
nofib-queens5x5/bjbt2 117300 μs 99280 μs 1.18
marlowe-semantics/004025fd712d6c325ffa12c16d157064192992faf62e0b991d7310a2f91666b8 1189 μs 858.3 μs 1.39
marlowe-semantics/0104010200020000040103020102020004040300030304040400010301040303 1146 μs 1016 μs 1.13
marlowe-semantics/12910f24d994d451ff379b12c9d1ecdb9239c9b87e5d7bea570087ec506935d5 723.4 μs 505.5 μs 1.43
marlowe-semantics/18cefc240debc0fcab14efdd451adfd02793093efe7bc76d6322aed6ddb582ad 1098 μs 768.3 μs 1.43
marlowe-semantics/1a2f2540121f09321216090b2b1f211e3f020c2c133a1a3c3f3c232a26153a04 445.2 μs 310.2 μs 1.44
marlowe-semantics/1a573aed5c46d637919ccb5548dfc22a55c9fc38298d567d15ee9f2eea69d89e 1322 μs 923.6 μs 1.43
marlowe-semantics/1d56060c3b271226064c672a282663643b1b0823471c67737f0b076870331260 1140 μs 793.4 μs 1.44
marlowe-semantics/1d6e3c137149a440f35e0efc685b16bfb8052ebcf66ec4ad77e51c11501381c7 442.6 μs 309.1 μs 1.43
marlowe-semantics/1f0f02191604101e1f201016171604060d010d1d1c150e110a110e1006160a0d 1472 μs 1040 μs 1.42
marlowe-semantics/202d273721330b31193405101e0637202e2a0f1140211c3e3f171e26312b0220 8303 μs 6014 μs 1.38
marlowe-semantics/21953bf8798b28df60cb459db24843fb46782b19ba72dc4951941fb4c20d2263 524.7 μs 365.5 μs 1.44
marlowe-semantics/238b21364ab5bdae3ddb514d7001c8feba128b4ddcf426852b441f9a9d02c882 438.7 μs 306.8 μs 1.43
marlowe-semantics/26e24ee631a6d927ea4fb4fac530cfd82ff7636986014de2d2aaa460ddde0bc3 823.7 μs 573.6 μs 1.44
marlowe-semantics/2797d7ac77c1b6aff8e42cf9a47fa86b1e60f22719a996871ad412cbe4de78b5 2667 μs 1888 μs 1.41
marlowe-semantics/28fdce478e179db0e38fb5f3f4105e940ece450b9ce8a0f42a6e313b752e6f2c 1365 μs 952.5 μs 1.43
marlowe-semantics/2cb21612178a2d9336b59d06cbf80488577463d209a453048a66c6eee624a695 1153 μs 801 μs 1.44
marlowe-semantics/2f58c9d884813042bce9cf7c66048767dff166785e8b5183c8139db2aa7312d1 1122 μs 785.4 μs 1.43
marlowe-semantics/30aa34dfbe89e0c43f569929a96c0d2b74c321d13fec0375606325eee9a34a6a 1683 μs 1174 μs 1.43
marlowe-semantics/322acde099bc34a929182d5b894214fc87ec88446e2d10625119a9d17fa3ec3d 443.7 μs 310.9 μs 1.43
marlowe-semantics/331e4a1bb30f28d7073c54f9a13c10ae19e2e396c299a0ce101ee6bf4b2020db 679.9 μs 476.5 μs 1.43
marlowe-semantics/33c3efd79d9234a78262b52bc6bbf8124cb321a467dedb278328215167eca455 920.1 μs 641.8 μs 1.43
marlowe-semantics/383683bfcecdab0f4df507f59631c702bd11a81ca3841f47f37633e8aacbb5de 1117 μs 778.1 μs 1.44
marlowe-semantics/3bb75b2e53eb13f718eacd3263ab4535f9137fabffc9de499a0de7cabb335479 436.9 μs 306 μs 1.43
marlowe-semantics/3db496e6cd39a8b888a89d0de07dace4397878958cab3b9d9353978b08c36d8a 1217 μs 846.8 μs 1.44
marlowe-semantics/44a9e339fa25948b48637fe7e10dcfc6d1256319a7b5ce4202cb54dfef8e37e7 436 μs 304.8 μs 1.43
marlowe-semantics/4c3efd13b6c69112a8a888372d56c86e60c232125976f29b1c3e21d9f537845c 1505 μs 1045 μs 1.44
marlowe-semantics/4d7adf91bfc93cebe95a7e054ec17cfbb912b32bd8aecb48a228b50e02b055c8 1020 μs 713.6 μs 1.43
marlowe-semantics/4f9e8d361b85e62db2350dd3ae77463540e7af0d28e1eb68faeecc45f4655f57 581.9 μs 405.7 μs 1.43
marlowe-semantics/52df7c8dfaa5f801cd837faa65f2fd333665fff00a555ce8c55e36ddc003007a 534.4 μs 371.1 μs 1.44
marlowe-semantics/53ed4db7ab33d6f907eec91a861d1188269be5ae1892d07ee71161bfb55a7cb7 543 μs 378.7 μs 1.43
marlowe-semantics/55dfe42688ad683b638df1fa7700219f00f53b335a85a2825502ab1e0687197e 439.4 μs 304.5 μs 1.44
marlowe-semantics/56333d4e413dbf1a665463bf68067f63c118f38f7539b7ba7167d577c0c8b8ce 1133 μs 795.3 μs 1.42
marlowe-semantics/57728d8b19b0e06412786f3dfed9e1894cd0ad1d2bc2bd497ec0ecb68f989d2b 436.8 μs 304.2 μs 1.44
marlowe-semantics/5abae75af26f45658beccbe48f7c88e74efdfc0b8409ba1e98f95fa5b6caf999 714.1 μs 499.4 μs 1.43
marlowe-semantics/5d0a88250f13c49c20e146819357a808911c878a0e0a7d6f7fe1d4a619e06112 1527 μs 1066 μs 1.43
marlowe-semantics/5e274e0f593511543d41570a4b03646c1d7539062b5728182e073e5760561a66 1474 μs 1033 μs 1.43
marlowe-semantics/5e2c68ac9f62580d626636679679b97109109df7ac1a8ce86d3e43dfb5e4f6bc 756.7 μs 526.7 μs 1.44
marlowe-semantics/5f130d19918807b60eab4c03119d67878fb6c6712c28c54f5a25792049294acc 445.8 μs 310.4 μs 1.44
marlowe-semantics/5f306b4b24ff2b39dab6cdc9ac6ca9bb442c1dc6f4e7e412eeb5a3ced42fb642 1106 μs 773.5 μs 1.43
marlowe-semantics/5f3d46c57a56cef6764f96c9de9677ac6e494dd7a4e368d1c8dd9c1f7a4309a5 718.5 μs 500.6 μs 1.44
marlowe-semantics/64c3d5b43f005855ffc4d0950a02fd159aa1575294ea39061b81a194ebb9eaae 973.5 μs 677.4 μs 1.44
marlowe-semantics/65bc4b69b46d18fdff0fadbf00dd5ec2b3e03805fac9d5fb4ff2d3066e53fc7e 3513 μs 2475 μs 1.42
marlowe-semantics/66af9e473d75e3f464971f6879cc0f2ef84bafcb38fbfa1dbc31ac2053628a38 1840 μs 1277 μs 1.44
marlowe-semantics/675d63836cad11b547d1b4cddd498f04c919d4342612accf40913f9ae9419fac 1524 μs 1055 μs 1.44
marlowe-semantics/67ba5a9a0245ee3aff4f34852b9889b8c810fccd3dce2a23910bddd35c503b71 7983 μs 5895 μs 1.35
marlowe-semantics/6d88f7294dd2b5ce02c3dc609bc7715bd508009738401d264bf9b3eb7c6f49c1 714.3 μs 500.2 μs 1.43
marlowe-semantics/70f65b21b77ddb451f3df9d9fb403ced3d10e1e953867cc4900cc25e5b9dec47 1153 μs 808.8 μs 1.43
marlowe-semantics/7a758e17486d1a30462c32a5d5309bd1e98322a9dcbe277c143ed3aede9d265f 753 μs 679.2 μs 1.11
marlowe-semantics/7cbc5644b745f4ea635aca42cce5e4a4b9d2e61afdb3ac18128e1688c07071ba 692.1 μs 484.7 μs 1.43

This comment was automatically generated by workflow using github-action-benchmark.

CC: @IntersectMBO/plutus-core

Please sign in to comment.