[PLT-8182] CIP-0087 support (#5654)

* Move conversion code into Plutus Core

* Documentation and notes on implementations

* Wrap implementations into builtins

* Properties as per CIP-0087

* CIP-0087 examples as tests

* Add new builtins to PlutusTx

* Document fromIntegral usage as a note

* Changelogs for CIP-0087 primitives

* Ensure conversions don't break on too-large arguments

* Ensure that conversions are available in V3

* Remove unnecessary pragmata on tests

* Fix overly-long test names, clarify test meaning in comments

* CIP link consistency

* Re-order integerToByteString arguments, avoid unnecessary padding

* Better documentation for implementations

* Correct properties for ByteStringToInteger

* Address feedback

plutus-core/changelog.d/20231127_134852_koz.ross_cip_0087.md

@@ -0,0 +1,41 @@
+<!--
+A new scriv changelog fragment.
+
+Uncomment the section that is right (remove the HTML comment wrapper).
+-->
+
+<!--
+### Removed
+
+- A bullet item for the Removed category.
+
+-->
+### Added
+
+- Implementations for the primitive operations described in
+  [CIP-0087](https://github.com/mlabs-haskell/CIPs/blob/koz/to-from-bytestring/CIP-0087/CIP-0087.md)
+
+<!--
+### Changed
+
+- A bullet item for the Changed category.
+
+-->
+<!--
+### Deprecated
+
+- A bullet item for the Deprecated category.
+
+-->
+<!--
+### Fixed
+
+- A bullet item for the Fixed category.
+
+-->
+<!--
+### Security
+
+- A bullet item for the Security category.
+
+-->

plutus-core/plutus-core.cabal

@@ -87,6 +87,7 @@ library
     PlutusCore.Annotation
     PlutusCore.Arity
     PlutusCore.Builtin
+    PlutusCore.Builtin.Convert
     PlutusCore.Builtin.Debug
     PlutusCore.Builtin.Elaborate
     PlutusCore.Builtin.Emitter
@@ -274,6 +275,7 @@ library
     , base64-bytestring
     , bimap
     , bytestring
+    , bytestring-strict-builder
     , cardano-crypto
     , cardano-crypto-class        ^>=2.1.2
     , cassava
@@ -401,6 +403,7 @@ test-suite untyped-plutus-core-test
     Evaluation.Builtins.BLS12_381.TestClasses
     Evaluation.Builtins.BLS12_381.Utils
     Evaluation.Builtins.Common
+    Evaluation.Builtins.Conversion
     Evaluation.Builtins.Costing
     Evaluation.Builtins.Definition
     Evaluation.Builtins.MakeRead

plutus-core/plutus-core/src/PlutusCore/Default/Builtins.hs

@@ -25,6 +25,7 @@ import PlutusCore.Evaluation.Machine.ExMemoryUsage
 import PlutusCore.Evaluation.Result
 import PlutusCore.Pretty
 
+import PlutusCore.Builtin.Convert as Convert
 import PlutusCore.Crypto.BLS12_381.G1 qualified as BLS12_381.G1
 import PlutusCore.Crypto.BLS12_381.G2 qualified as BLS12_381.G2
 import PlutusCore.Crypto.BLS12_381.Pairing qualified as BLS12_381.Pairing
@@ -147,6 +148,9 @@ data DefaultFun
     -- Keccak_256, Blake2b_224
     | Keccak_256
     | Blake2b_224
+    -- Conversions
+    | IntegerToByteString
+    | ByteStringToInteger
     deriving stock (Show, Eq, Ord, Enum, Bounded, Generic, Ix)
     deriving anyclass (NFData, Hashable, PrettyBy PrettyConfigPlc)
 
@@ -1803,6 +1807,22 @@ instance uni ~ DefaultUni => ToBuiltinMeaning uni DefaultFun where
         in makeBuiltinMeaning
             blake2b_224Denotation
             (runCostingFunOneArgument . paramBlake2b_224)
+
+    -- Conversions
+    toBuiltinMeaning _semvar IntegerToByteString =
+      let integerToByteStringDenotation :: Bool -> Integer -> Integer -> Emitter (EvaluationResult BS.ByteString)
+          integerToByteStringDenotation = integerToByteStringWrapper
+        in makeBuiltinMeaning
+          integerToByteStringDenotation
+          -- FIXME: Cost this function.
+          (runCostingFunThreeArguments . const def)
+    toBuiltinMeaning _semvar ByteStringToInteger =
+      let byteStringToIntegerDenotation :: Bool -> BS.ByteString -> Integer
+          byteStringToIntegerDenotation = byteStringToIntegerWrapper
+        in makeBuiltinMeaning
+            byteStringToIntegerDenotation
+            -- FIXME: Cost this function.
+            (runCostingFunTwoArguments . const def)
     -- See Note [Inlining meanings of builtins].
     {-# INLINE toBuiltinMeaning #-}
 
@@ -1911,6 +1931,9 @@ instance Flat DefaultFun where
               Keccak_256                      -> 71
               Blake2b_224                     -> 72
 
+              IntegerToByteString             -> 73
+              ByteStringToInteger             -> 74
+
     decode = go =<< decodeBuiltin
         where go 0  = pure AddInteger
               go 1  = pure SubtractInteger
@@ -1985,6 +2008,8 @@ instance Flat DefaultFun where
               go 70 = pure Bls12_381_finalVerify
               go 71 = pure Keccak_256
               go 72 = pure Blake2b_224
+              go 73 = pure IntegerToByteString
+              go 74 = pure ByteStringToInteger
               go t  = fail $ "Failed to decode builtin tag, got: " ++ show t
 
     size _ n = n + builtinTagWidth

plutus-core/plutus-core/test/TypeSynthesis/Golden/DefaultFun/ByteStringToInteger.plc.golden

@@ -0,0 +1 @@
+bool -> bytestring -> integer

plutus-core/plutus-core/test/TypeSynthesis/Golden/DefaultFun/IntegerToByteString.plc.golden

@@ -0,0 +1 @@
+bool -> integer -> integer -> bytestring

plutus-core/plutus-ir/src/PlutusIR/Transform/RewriteRules/CommuteFnWithConst.hs

@@ -127,3 +127,5 @@ isCommutative = \case
   MkPairData                      -> False
   MkNilData                       -> False
   MkNilPairData                   -> False
+  IntegerToByteString             -> False
+  ByteStringToInteger             -> False