Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CGP-365] [Constants] Use 'BlockNum', remove 'BlockTime' #176

Merged
merged 1 commit into from
Oct 6, 2018
Merged

[CGP-365] [Constants] Use 'BlockNum', remove 'BlockTime' #176

merged 1 commit into from
Oct 6, 2018

Conversation

effectfully
Copy link
Contributor

No description provided.

@effectfully effectfully force-pushed the effectfully/CGP-365/use-BlockNum-remove-BlockTime branch from 2386a7f to 6591ba5 Compare October 5, 2018 13:49
vmchale
vmchale approved these changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@vmchale vmchale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the spec still mentions btime in the types for builtin names. We may want to remove that as well.

@effectfully
Copy link
Contributor Author

I believe that the spec still mentions btime in the types for builtin names. We may want to remove that as well.

Asked Rebecca in slack.

@effectfully effectfully merged commit ca40992 into IntersectMBO:master Oct 6, 2018
@effectfully effectfully deleted the effectfully/CGP-365/use-BlockNum-remove-BlockTime branch October 6, 2018 11:17
@rmourey26 rmourey26 mentioned this pull request Nov 5, 2022
Open
@rmourey26 rmourey26 mentioned this pull request Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmchale vmchale vmchale approved these changes

@mchakravarty mchakravarty Awaiting requested review from mchakravarty

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@effectfully @vmchale