Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCP-2041 - Buttons hover over "open example" window's title #3000

Merged
merged 1 commit into from
Apr 13, 2021
Merged

SCP-2041 - Buttons hover over "open example" window's title #3000

merged 1 commit into from
Apr 13, 2021

Conversation

palas
Copy link
Contributor

@palas palas commented Apr 13, 2021 •
edited
Loading

Just changes the z-index of the header of the modal so that buttons don't hover over.

Before:
before

After:
after

Pre-submit checklist:

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, materialized Nix files, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Pre-merge checklist:

  • Someone approved it
  • Commits have useful messages
  • Review clarifications made it into the code
  • History is moderately tidy; or going to squash-merge

@palas palas requested a review from hrajchert April 13, 2021 14:55
@palas palas self-assigned this Apr 13, 2021
hrajchert
hrajchert approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@hrajchert hrajchert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hrajchert hrajchert merged commit 8d804f1 into master Apr 13, 2021
@palas palas deleted the SCP-2041 branch April 13, 2021 18:53
@rmourey26 rmourey26 mentioned this pull request Sep 8, 2022
Open
@rmourey26 rmourey26 mentioned this pull request Dec 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrajchert hrajchert hrajchert approved these changes

Assignees

@palas palas

Labels
User experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palas @hrajchert