Add Plutus implementation of mapM_ (fix #3203). #3209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
approved these changes
May 18, 2021
j-mueller
reviewed
May 19, 2021
plutus-tx/src/PlutusTx/Foldable.hs
Outdated
| {-# INLINABLE mapM_ #-} | ||
| mapM_ :: (Foldable t, Monad m) => (a -> m b) -> t a -> m () | ||
| mapM_ f = foldr c (return ()) | ||
| -- See Note [List fusion and continuations in 'c'] |
There was a problem hiding this comment.
Where is this note? And does it apply to Plutus?
There was a problem hiding this comment.
I was looking at https://hackage.haskell.org/package/base-4.15.0.0/docs/src/Data-Foldable.html#mapM_
Yeah, not sure about Plutus, removed.
| @@ -201,3 +209,10 @@ find p = getFirst . foldMap (\ x -> First (if p x then Just x else Nothing)) | |||
| (#.) :: Coercible b c => (b -> c) -> (a -> b) -> (a -> c) | |||
| (#.) _f = coerce | |||
| {-# INLINE (#.) #-} | |||
|
|
|||
| {-# INLINABLE mapM_ #-} | |||
| mapM_ :: (Foldable t, Monad m) => (a -> m b) -> t a -> m () | |||
There was a problem hiding this comment.
Haddocks: "Plutus version of 'Control.Monad.mapM_'
We should probably also add mapM
There was a problem hiding this comment.
Yeah, fixed, but to Data.Foldable.mapM_ because that's the original location. And mapM is already in PlutusTx.Traversable.
j-mueller
approved these changes
May 19, 2021
ghost
force-pushed
the
plutus-prelude-mapm
branch
from
fd5e2a9
to
338c855
Compare
|
@michaelpj I have rebased the PR, should be possible to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem in #3203 is that PlutusTx.Prelude re-exports Prelude.mapM_ which fails to compile. The fix is to add Plutus's own implementation.
Pre-submit checklist:
Pre-merge checklist: