SCP-2092: Implement new design of contract cards. #3556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrajchert
approved these changes
Jul 15, 2021
| handleAction _ (SetNickname nickname) = do | ||
| handleAction { followerAppId } SelectSelf = callMainFrameAction $ MainFrame.DashboardAction $ Dashboard.SelectContract $ Just followerAppId | ||
|
|
||
| handleAction { followerAppId } (SetNickname nickname) = do |
There was a problem hiding this comment.
We are not using the app id here right?
handleAction _ (SetNickname nickname)There was a problem hiding this comment.
yes, we need it to insertIntoContractNicknames (contractNicknames is a Map PlutusAppId String)
| , type_ InputText | ||
| , value nickname | ||
| , onValueInput_ SetNickname | ||
| , placeholder "Please rename" |
There was a problem hiding this comment.
is the Please rename something for us internal to remember we have to rename? if so, it's probably worth to add a FIXME. If it's for the end user we might want to ask Niahm for some copy
There was a problem hiding this comment.
this isn't a note for us - this is the text Russ included in his designs
merivale
force-pushed
the
merivale/contract-card-redux
branch
3 times, most recently
from
3fd0ef7 to
3596af5
Compare
merivale
force-pushed
the
merivale/contract-card-redux
branch
from
3596af5 to
8960485
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the new designs for the dashboard, with the contract summary cards including the actions possible at the current step. I haven't changed the style of the actions themselves, since that change also applies to the current step card on the contract screen - and I'll attack the contract screen in the next PR. This PR already feels quite big enough, especially the diff of the Contract.View module.
Until now, the
selectedContractIndexin theDashboard.Statewas doing two things: determining which contract screen was visible, and also which contract anyContract.Actionapplied to. In the new designs, aContract.Actionfor any contract can be called from the dashboard, without the need to first go into the screen for that contract, so these two things needed to come apart. I left theselectedContractIndexto determine which contract screen is visible, and added an contract index (PlutusAppId) parameter toContractAction.While I was at it, I deleted the
followerAppIdfrom theContract.State, which is duplicate information already available as the key of the contract map in theDashboard.State. Instead I'm passing this asinputto the contract action handlers, which feels nicer. And because the contract view needs to know about this, I changed the partitioned arrays of contracts (running / completed) to maps. Since the filter functions are being called every second, we might want to store these as separate maps in the sate - but I haven't noticed any performance issues yet, so I'm not too worried about it.