SCP-2512: plutus-use-cases-scripts is now run during Hydra CI #3594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koslambrou
force-pushed
the
scp-2512-puc-scripts-hydra
branch
from
22ef154 to
b9718f3
Compare
j-mueller
reviewed
Jul 22, 2021
| ln -s ${haskell.packages.plutus-use-cases.src}/scripts/protocol-parameters.json protocol-parameters.json | ||
| ${puc-scripts-invoker}/bin/plutus-use-cases-scripts $out/scripts scripts | ||
| # Mainnet address is used because no networkid is specified (with the '-n' flag) | ||
| ${puc-scripts-invoker}/bin/plutus-use-cases-scripts $out/transactions transactions -p protocol-parameters.json |
There was a problem hiding this comment.
can you also please make a tar or zip file containing both folders? That's easier than downloading each script individually
There was a problem hiding this comment.
Oh yeah, good idea!
koslambrou
force-pushed
the
scp-2512-puc-scripts-hydra
branch
from
b9718f3 to
96cc9a0
Compare
j-mueller
approved these changes
Jul 22, 2021
…t is available for download from Hydra.
koslambrou
force-pushed
the
scp-2512-puc-scripts-hydra
branch
from
96cc9a0 to
c598bd1
Compare
|
Yes that looks good, thanks! |
michaelpj
reviewed
Jul 26, 2021
| generated-puc-scripts-output = pkgs.runCommand "plutus-use-cases-scripts-output" { } '' | ||
| mkdir -p $out/scripts | ||
| mkdir -p $out/transactions | ||
| ln -s ${haskell.packages.plutus-use-cases.src}/scripts/protocol-parameters.json protocol-parameters.json |
There was a problem hiding this comment.
You can just pick up the file from the source tree, no need to do this roundabout thing. Something like ${builtins.readFile ./scripts/protocol-paramters.json}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plutus-use-cases-scripts is now run during Hydra CI and the result is available for download from Hydra.
Pre-submit checklist:
Pre-merge checklist: