plutus-tx-plugin: store PIR in code as well as PLC, use in tests #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store the serialized PIR code in the program as well. This is useful for debugging and testing. As a witness to that, we can use it for the `plutus-tx` and `plutus-tx-plugin` tests, producing much shorter and more comprehensible outputs. (Indeed, I've spotted a couple of potential bugs doing this that had escaped me in the more verbose output)
michaelpj
force-pushed
the
imp/pir-in-program
branch
from
33ea373
to
4bbd428
Compare
effectfully
approved these changes
Dec 4, 2018
| correctly etc. But since it *is* just a wrapper... we can just put in a coercion! | ||
|
|
||
| Very nice and easy, but we need to make sure we don't stop being a simple newtype | ||
| without revisiting this. |
There was a problem hiding this comment.
This is no longer true?
There was a problem hiding this comment.
Indeed, now it's a datatype and we actually get the data constructor and construct it properly.
|
( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store the serialized PIR code in the program as well. This is useful for
debugging and testing.
As a witness to that, we can use it for the
plutus-txandplutus-tx-plugintests, producing much shorter and more comprehensibleoutputs. (Indeed, I've spotted a couple of potential bugs doing this
that had escaped me in the more verbose output)
I also want to use this in the tutorial/my demo, but I'll do that in a follow-up.