SCP-2545 - Marlowe Run Client - Implement transaction summary #3656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palas
approved these changes
Jul 31, 2021
| if min' `mod` 60 == zero then | ||
| show hours | ||
| else | ||
| show hours <> ":" <> formatMinutes (min' - hours * 60) |
There was a problem hiding this comment.
Nice, it even considers minute offsets, cool :)
|
Oh, I see now |
|
Yes, i dont like the order either, but i tried to be consistent with Deposit |
This was referenced Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a tooltip to the past actions card with the timezone information and includes an initial version of the transaction/payment summary.
While I was implementing this feature, I discovered a bug in the balance tab of the simple escrow example. When the buyer deposits and chooses to report a problem, there is a payment from the Sellers account to the Buyers account (which is shown by the new payment summary). But in the balances tab the money is removed from the Sellers account but is not added to the Buyers.
Pre-submit checklist: