[Builtins] Store constants in a data instance
#4200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to effectfully/builtins/introduce-HiddenValueOf
effectfully
commented
Nov 7, 2021
plutus-core/plutus-core/examples/PlutusCore/Examples/Builtins.hs
Outdated
Show resolved
Hide resolved
michaelpj
reviewed
Nov 8, 2021
| @@ -337,6 +342,17 @@ data Kinded uni ta where | |||
| type ValueOf :: (Type -> Type) -> Type -> Type | |||
| data ValueOf uni a = ValueOf !(uni (Esc a)) !a | |||
|
|
|||
| type HiddenValueOf :: (Type -> Type) -> Type | |||
| data family HiddenValueOf uni | |||
There was a problem hiding this comment.
why not make this a member of the HasHiddenValueOf class?
| @@ -337,6 +342,17 @@ data Kinded uni ta where | |||
| type ValueOf :: (Type -> Type) -> Type -> Type | |||
| data ValueOf uni a = ValueOf !(uni (Esc a)) !a | |||
|
|
|||
| type HiddenValueOf :: (Type -> Type) -> Type | |||
There was a problem hiding this comment.
name bikeshedding: SpecializedValueOf? Since basically the point is to be a specialized version of ValueOf for the given universe.
| @@ -417,6 +433,10 @@ someValueOf uni = Some . ValueOf uni | |||
| someValue :: forall a uni. uni `Includes` a => a -> Some (ValueOf uni) | |||
| someValue = someValueOf knownUni | |||
|
|
|||
| -- | Wrap a value into @HiddenValueOf uni@, provided its type is in the universe. | |||
| hiddenValue :: forall a uni. (HasHiddenValueOf uni, uni `Includes` a) => a -> HiddenValueOf uni | |||
| hiddenValue = hiddenValueOf knownUni | |||
There was a problem hiding this comment.
I wonder if fromSomeValueOf . someValueOf knownUni would optimize as well.
|
/benchmark |
9 tasks
|
It appears to be worse! #4243 (comment) However, I wonder if we'd only really benefit from this if we specialized the CEK machine on |
|
Superseded by #4249. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt at Kmett's idea to store constants in a
data instance(the previous one was #4196). Largely straightforward, there's just one slight twist.Don't look here yet. There are no docs and this PR needs to be benchmarked first.