Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Builtins] Make 'toBuiltinRuntime' a class method #4418

Closed
wants to merge 3 commits into from
Closed

[Builtins] Make 'toBuiltinRuntime' a class method #4418

wants to merge 3 commits into from

Conversation

effectfully
Copy link
Contributor

Don't look here yet.

@effectfully effectfully force-pushed the effectfully/builtins/toBuiltinRuntime-as-a-class-method branch from 73a6ad5 to 89eab5e Compare February 19, 2022 10:39
@effectfully
Copy link
Contributor Author

/benchmark plutus-benchmark:validation

@iohk-devops
Copy link

Comparing benchmark results of 'plutus-benchmark:validation' on '0397f83b8' (base) and '89eab5e2e' (PR)

Script 0397f83 89eab5e Change
auction_1-1 279.1 μs 258.9 μs -7.2%
auction_1-2 939.7 μs 902.5 μs -4.0%
auction_1-3 934.3 μs 896.2 μs -4.1%
auction_1-4 364.8 μs 337.7 μs -7.4%
auction_2-1 281.3 μs 259.9 μs -7.6%
auction_2-2 935.7 μs 904.2 μs -3.4%
auction_2-3 1.187 ms 1.152 ms -2.9%
auction_2-4 929.5 μs 898.9 μs -3.3%
auction_2-5 363.4 μs 339.2 μs -6.7%
crowdfunding-success-1 331.1 μs 304.7 μs -8.0%
crowdfunding-success-2 331.4 μs 306.0 μs -7.7%
crowdfunding-success-3 330.1 μs 306.3 μs -7.2%
currency-1 367.0 μs 347.4 μs -5.3%
escrow-redeem_1-1 535.8 μs 503.8 μs -6.0%
escrow-redeem_1-2 534.5 μs 504.3 μs -5.7%
escrow-redeem_2-1 627.7 μs 590.9 μs -5.9%
escrow-redeem_2-2 628.8 μs 590.6 μs -6.1%
escrow-redeem_2-3 627.4 μs 589.2 μs -6.1%
escrow-refund-1 246.0 μs 227.5 μs -7.5%
future-increase-margin-1 367.4 μs 346.7 μs -5.6%
future-increase-margin-2 810.1 μs 775.4 μs -4.3%
future-increase-margin-3 809.8 μs 775.5 μs -4.2%
future-increase-margin-4 751.2 μs 715.9 μs -4.7%
future-increase-margin-5 1.148 ms 1.102 ms -4.0%
future-pay-out-1 367.0 μs 347.2 μs -5.4%
future-pay-out-2 812.1 μs 775.1 μs -4.6%
future-pay-out-3 811.0 μs 776.8 μs -4.2%
future-pay-out-4 1.150 ms 1.109 ms -3.6%
future-settle-early-1 369.1 μs 348.4 μs -5.6%
future-settle-early-2 814.6 μs 775.3 μs -4.8%
future-settle-early-3 814.3 μs 774.5 μs -4.9%
future-settle-early-4 888.2 μs 848.9 μs -4.4%
game-sm-success_1-1 597.9 μs 565.5 μs -5.4%
game-sm-success_1-2 310.5 μs 286.7 μs -7.7%
game-sm-success_1-3 934.8 μs 897.7 μs -4.0%
game-sm-success_1-4 362.1 μs 336.5 μs -7.1%
game-sm-success_2-1 598.5 μs 566.4 μs -5.4%
game-sm-success_2-2 310.9 μs 286.6 μs -7.8%
game-sm-success_2-3 936.2 μs 900.4 μs -3.8%
game-sm-success_2-4 362.1 μs 337.2 μs -6.9%
game-sm-success_2-5 936.6 μs 900.5 μs -3.9%
game-sm-success_2-6 363.9 μs 337.6 μs -7.2%
multisig-sm-1 608.6 μs 575.6 μs -5.4%
multisig-sm-2 596.4 μs 563.6 μs -5.5%
multisig-sm-3 601.8 μs 569.5 μs -5.4%
multisig-sm-4 608.4 μs 574.0 μs -5.7%
multisig-sm-5 834.0 μs 795.1 μs -4.7%
multisig-sm-6 606.1 μs 572.8 μs -5.5%
multisig-sm-7 593.6 μs 562.3 μs -5.3%
multisig-sm-8 598.2 μs 569.3 μs -4.8%
multisig-sm-9 607.0 μs 575.2 μs -5.2%
multisig-sm-10 831.8 μs 795.0 μs -4.4%
ping-pong-1 499.2 μs 471.6 μs -5.5%
ping-pong-2 497.6 μs 473.7 μs -4.8%
ping-pong_2-1 308.2 μs 289.7 μs -6.0%
prism-1 261.2 μs 238.6 μs -8.7%
prism-2 648.5 μs 613.4 μs -5.4%
prism-3 555.6 μs 526.3 μs -5.3%
pubkey-1 221.3 μs 203.0 μs -8.3%
stablecoin_1-1 1.303 ms 1.250 ms -4.1%
stablecoin_1-2 304.0 μs 279.3 μs -8.1%
stablecoin_1-3 1.493 ms 1.431 ms -4.2%
stablecoin_1-4 324.8 μs 297.6 μs -8.4%
stablecoin_1-5 1.907 ms 1.806 ms -5.3%
stablecoin_1-6 403.0 μs 370.0 μs -8.2%
stablecoin_2-1 1.311 ms 1.251 ms -4.6%
stablecoin_2-2 304.9 μs 278.8 μs -8.6%
stablecoin_2-3 1.503 ms 1.428 ms -5.0%
stablecoin_2-4 324.3 μs 297.2 μs -8.4%
token-account-1 284.6 μs 265.4 μs -6.7%
token-account-2 496.9 μs 466.9 μs -6.0%
uniswap-1 593.0 μs 567.1 μs -4.4%
uniswap-2 340.1 μs 320.6 μs -5.7%
uniswap-3 2.440 ms 2.320 ms -4.9%
uniswap-4 529.7 μs 491.3 μs -7.2%
uniswap-5 1.711 ms 1.614 ms -5.7%
uniswap-6 504.9 μs 470.0 μs -6.9%
vesting-1 520.5 μs 492.2 μs -5.4%

@effectfully
Copy link
Contributor Author

/benchmark plutus-benchmark:validation-full

@iohk-devops
Copy link

Comparing benchmark results of 'plutus-benchmark:validation-full' on '0397f83b8' (base) and '89eab5e2e' (PR)

Script 0397f83 89eab5e Change
auction_1-1 872.1 μs 853.6 μs -2.1%
auction_1-2 2.938 ms 2.896 ms -1.4%
auction_1-3 2.931 ms 2.901 ms -1.0%
auction_1-4 1.002 ms 967.9 μs -3.4%
auction_2-1 875.3 μs 853.9 μs -2.4%
auction_2-2 2.917 ms 2.902 ms -0.5%
auction_2-3 3.186 ms 3.168 ms -0.6%
auction_2-4 2.931 ms 2.918 ms -0.4%
auction_2-5 1.003 ms 972.1 μs -3.1%
crowdfunding-success-1 1.109 ms 1.089 ms -1.8%
crowdfunding-success-2 1.108 ms 1.089 ms -1.7%
crowdfunding-success-3 1.106 ms 1.086 ms -1.8%
currency-1 1.130 ms 1.114 ms -1.4%
escrow-redeem_1-1 1.620 ms 1.638 ms +1.1%
escrow-redeem_1-2 1.629 ms 1.639 ms +0.6%
escrow-redeem_2-1 1.796 ms 1.740 ms -3.1%
escrow-redeem_2-2 1.791 ms 1.742 ms -2.7%
escrow-redeem_2-3 1.789 ms 1.737 ms -2.9%
escrow-refund-1 1.299 ms 1.281 ms -1.4%
future-increase-margin-1 1.128 ms 1.115 ms -1.2%
future-increase-margin-2 2.010 ms 1.979 ms -1.5%
future-increase-margin-3 2.014 ms 1.978 ms -1.8%
future-increase-margin-4 3.166 ms 3.134 ms -1.0%
future-increase-margin-5 3.697 ms 3.646 ms -1.4%
future-pay-out-1 1.127 ms 1.108 ms -1.7%
future-pay-out-2 2.019 ms 1.981 ms -1.9%
future-pay-out-3 2.016 ms 1.994 ms -1.1%
future-pay-out-4 3.704 ms 3.674 ms -0.8%
future-settle-early-1 1.125 ms 1.109 ms -1.4%
future-settle-early-2 2.015 ms 1.985 ms -1.5%
future-settle-early-3 2.013 ms 1.979 ms -1.7%
future-settle-early-4 3.301 ms 3.272 ms -0.9%
game-sm-success_1-1 2.520 ms 2.496 ms -1.0%
game-sm-success_1-2 816.4 μs 791.7 μs -3.0%
game-sm-success_1-3 2.886 ms 2.845 ms -1.4%
game-sm-success_1-4 898.4 μs 865.6 μs -3.7%
game-sm-success_2-1 2.537 ms 2.505 ms -1.3%
game-sm-success_2-2 818.1 μs 793.4 μs -3.0%
game-sm-success_2-3 2.875 ms 2.850 ms -0.9%
game-sm-success_2-4 895.6 μs 869.3 μs -2.9%
game-sm-success_2-5 2.873 ms 2.849 ms -0.8%
game-sm-success_2-6 892.5 μs 867.9 μs -2.8%
multisig-sm-1 2.696 ms 2.704 ms +0.3%
multisig-sm-2 2.702 ms 2.674 ms -1.0%
multisig-sm-3 2.727 ms 2.692 ms -1.3%
multisig-sm-4 2.680 ms 2.705 ms +0.9%
multisig-sm-5 2.950 ms 2.936 ms -0.5%
multisig-sm-6 2.699 ms 2.721 ms +0.8%
multisig-sm-7 2.712 ms 2.701 ms -0.4%
multisig-sm-8 2.731 ms 2.706 ms -0.9%
multisig-sm-9 2.697 ms 2.724 ms +1.0%
multisig-sm-10 2.956 ms 2.930 ms -0.9%
ping-pong-1 2.270 ms 2.281 ms +0.5%
ping-pong-2 2.268 ms 2.269 ms +0.0%
ping-pong_2-1 1.979 ms 1.960 ms -1.0%
prism-1 732.3 μs 711.9 μs -2.8%
prism-2 2.539 ms 2.518 ms -0.8%
prism-3 1.365 ms 1.337 ms -2.1%
pubkey-1 708.8 μs 695.2 μs -1.9%
stablecoin_1-1 4.630 ms 4.582 ms -1.0%
stablecoin_1-2 806.2 μs 785.3 μs -2.6%
stablecoin_1-3 4.823 ms 4.751 ms -1.5%
stablecoin_1-4 833.0 μs 811.4 μs -2.6%
stablecoin_1-5 5.225 ms 5.139 ms -1.6%
stablecoin_1-6 950.1 μs 925.6 μs -2.6%
stablecoin_2-1 4.602 ms 4.606 ms +0.1%
stablecoin_2-2 809.4 μs 787.0 μs -2.8%
stablecoin_2-3 4.829 ms 4.776 ms -1.1%
stablecoin_2-4 837.4 μs 814.1 μs -2.8%
token-account-1 1.026 ms 1.016 ms -1.0%
token-account-2 1.225 ms 1.191 ms -2.8%
uniswap-1 1.398 ms 1.359 ms -2.8%
uniswap-2 1.099 ms 1.082 ms -1.5%
uniswap-3 5.260 ms 5.102 ms -3.0%
uniswap-4 1.172 ms 1.134 ms -3.2%
uniswap-5 4.411 ms 4.264 ms -3.3%
uniswap-6 1.140 ms 1.098 ms -3.7%
vesting-1 1.665 ms 1.622 ms -2.6%

@effectfully
Copy link
Contributor Author

/benchmark plutus-benchmark:validation

@iohk-devops
Copy link

Comparing benchmark results of 'plutus-benchmark:validation' on '0397f83b8' (base) and '89eab5e2e' (PR)

Script 0397f83 89eab5e Change
auction_1-1 278.8 μs 258.4 μs -7.3%
auction_1-2 935.6 μs 901.2 μs -3.7%
auction_1-3 930.7 μs 897.8 μs -3.5%
auction_1-4 364.1 μs 338.8 μs -6.9%
auction_2-1 279.2 μs 259.9 μs -6.9%
auction_2-2 937.7 μs 902.4 μs -3.8%
auction_2-3 1.189 ms 1.149 ms -3.4%
auction_2-4 931.7 μs 896.5 μs -3.8%
auction_2-5 363.2 μs 338.7 μs -6.7%
crowdfunding-success-1 330.2 μs 305.8 μs -7.4%
crowdfunding-success-2 331.8 μs 305.5 μs -7.9%
crowdfunding-success-3 333.0 μs 305.6 μs -8.2%
currency-1 369.4 μs 347.5 μs -5.9%
escrow-redeem_1-1 535.5 μs 505.9 μs -5.5%
escrow-redeem_1-2 536.0 μs 505.2 μs -5.7%
escrow-redeem_2-1 626.8 μs 593.7 μs -5.3%
escrow-redeem_2-2 626.1 μs 592.7 μs -5.3%
escrow-redeem_2-3 624.3 μs 591.8 μs -5.2%
escrow-refund-1 244.1 μs 226.1 μs -7.4%
future-increase-margin-1 366.3 μs 347.9 μs -5.0%
future-increase-margin-2 812.6 μs 773.2 μs -4.8%
future-increase-margin-3 810.7 μs 774.0 μs -4.5%
future-increase-margin-4 752.3 μs 715.0 μs -5.0%
future-increase-margin-5 1.146 ms 1.100 ms -4.0%
future-pay-out-1 367.8 μs 346.8 μs -5.7%
future-pay-out-2 816.8 μs 775.0 μs -5.1%
future-pay-out-3 813.4 μs 775.1 μs -4.7%
future-pay-out-4 1.147 ms 1.103 ms -3.8%
future-settle-early-1 365.8 μs 348.0 μs -4.9%
future-settle-early-2 810.4 μs 775.2 μs -4.3%
future-settle-early-3 808.2 μs 774.6 μs -4.2%
future-settle-early-4 887.4 μs 848.4 μs -4.4%
game-sm-success_1-1 598.6 μs 567.6 μs -5.2%
game-sm-success_1-2 310.1 μs 288.2 μs -7.1%
game-sm-success_1-3 937.4 μs 904.1 μs -3.6%
game-sm-success_1-4 362.3 μs 338.0 μs -6.7%
game-sm-success_2-1 601.1 μs 569.2 μs -5.3%
game-sm-success_2-2 312.4 μs 287.4 μs -8.0%
game-sm-success_2-3 938.8 μs 901.3 μs -4.0%
game-sm-success_2-4 363.9 μs 337.2 μs -7.3%
game-sm-success_2-5 938.2 μs 900.4 μs -4.0%
game-sm-success_2-6 363.0 μs 336.4 μs -7.3%
multisig-sm-1 607.0 μs 575.5 μs -5.2%
multisig-sm-2 591.9 μs 562.9 μs -4.9%
multisig-sm-3 599.9 μs 566.6 μs -5.6%
multisig-sm-4 607.7 μs 577.1 μs -5.0%
multisig-sm-5 832.5 μs 797.7 μs -4.2%
multisig-sm-6 606.0 μs 573.0 μs -5.4%
multisig-sm-7 593.4 μs 562.6 μs -5.2%
multisig-sm-8 601.0 μs 567.6 μs -5.6%
multisig-sm-9 607.6 μs 577.8 μs -4.9%
multisig-sm-10 835.1 μs 799.4 μs -4.3%
ping-pong-1 498.8 μs 475.3 μs -4.7%
ping-pong-2 499.9 μs 475.1 μs -5.0%
ping-pong_2-1 309.3 μs 289.2 μs -6.5%
prism-1 259.5 μs 237.8 μs -8.4%
prism-2 646.7 μs 611.8 μs -5.4%
prism-3 554.4 μs 524.2 μs -5.4%
pubkey-1 220.2 μs 202.7 μs -7.9%
stablecoin_1-1 1.312 ms 1.252 ms -4.6%
stablecoin_1-2 304.6 μs 280.5 μs -7.9%
stablecoin_1-3 1.505 ms 1.432 ms -4.9%
stablecoin_1-4 324.5 μs 298.0 μs -8.2%
stablecoin_1-5 1.906 ms 1.811 ms -5.0%
stablecoin_1-6 401.7 μs 370.6 μs -7.7%
stablecoin_2-1 1.309 ms 1.255 ms -4.1%
stablecoin_2-2 304.0 μs 281.5 μs -7.4%
stablecoin_2-3 1.493 ms 1.438 ms -3.7%
stablecoin_2-4 322.9 μs 298.4 μs -7.6%
token-account-1 283.7 μs 267.5 μs -5.7%
token-account-2 497.2 μs 467.8 μs -5.9%
uniswap-1 594.6 μs 568.0 μs -4.5%
uniswap-2 340.8 μs 318.8 μs -6.5%
uniswap-3 2.445 ms 2.312 ms -5.4%
uniswap-4 530.7 μs 490.8 μs -7.5%
uniswap-5 1.710 ms 1.613 ms -5.7%
uniswap-6 505.6 μs 468.5 μs -7.3%
vesting-1 520.1 μs 492.5 μs -5.3%

@effectfully
Copy link
Contributor Author

/benchmark plutus-benchmark:nofib

@iohk-devops
Copy link

Comparing benchmark results of 'plutus-benchmark:nofib' on '0397f83b8' (base) and '89eab5e2e' (PR)

Script 0397f83 89eab5e Change
clausify/formula1 23.17 ms 23.03 ms -0.6%
clausify/formula2 28.74 ms 28.45 ms -1.0%
clausify/formula3 77.97 ms 77.84 ms -0.2%
clausify/formula4 132.5 ms 130.2 ms -1.7%
clausify/formula5 497.6 ms 493.3 ms -0.9%
knights/4x4 71.32 ms 69.49 ms -2.6%
knights/6x6 190.8 ms 184.3 ms -3.4%
knights/8x8 314.7 ms 305.1 ms -3.1%
primetest/05digits 51.14 ms 46.70 ms -8.7%
primetest/08digits 95.04 ms 86.08 ms -9.4%
primetest/10digits 134.1 ms 121.3 ms -9.5%
primetest/20digits 268.7 ms 243.7 ms -9.3%
primetest/30digits 389.9 ms 352.6 ms -9.6%
primetest/40digits 521.1 ms 477.0 ms -8.5%
primetest/50digits 518.2 ms 469.8 ms -9.3%
queens4x4/bt 11.73 ms 11.27 ms -3.9%
queens4x4/bm 16.65 ms 15.95 ms -4.2%
queens4x4/bjbt1 14.49 ms 14.03 ms -3.2%
queens4x4/bjbt2 15.39 ms 14.89 ms -3.2%
queens4x4/fc 35.93 ms 35.02 ms -2.5%
queens5x5/bt 158.5 ms 151.5 ms -4.4%
queens5x5/bm 193.3 ms 185.0 ms -4.3%
queens5x5/bjbt1 186.8 ms 179.8 ms -3.7%
queens5x5/bjbt2 196.3 ms 189.7 ms -3.4%
queens5x5/fc 459.0 ms 446.6 ms -2.7%

@effectfully effectfully mentioned this pull request Feb 19, 2022
Closed
@effectfully
Copy link
Contributor Author

Closing in favor of #4419 and some future PR.

@effectfully effectfully deleted the effectfully/builtins/toBuiltinRuntime-as-a-class-method branch February 20, 2022 04:45
@effectfully effectfully restored the effectfully/builtins/toBuiltinRuntime-as-a-class-method branch February 21, 2022 03:42
@effectfully effectfully deleted the effectfully/builtins/toBuiltinRuntime-as-a-class-method branch February 21, 2022 03:43
@effectfully effectfully restored the effectfully/builtins/toBuiltinRuntime-as-a-class-method branch February 27, 2022 18:44
@effectfully effectfully deleted the effectfully/builtins/toBuiltinRuntime-as-a-class-method branch May 5, 2022 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Builtins Don't look here yet Evaluation Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@effectfully @iohk-devops