PIR: restructure tests #5570
Merged
PIR: restructure tests #5570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
thealmarty
reviewed
Oct 2, 2023
thealmarty
reviewed
Oct 2, 2023
| rename | ||
| , test_scopingSpoilRenamer genProgram markNonFreshProgram | ||
| , T.test_scopingSpoilRenamer genProgram markNonFreshProgram | ||
| renameProgramM | ||
| -- Can't test substitution procedures at the moment, because that requires generating | ||
| -- functions. | ||
| , -- The pass breals global uniqueness by design. |
thealmarty
reviewed
Oct 2, 2023
| pure . recSplit | ||
| , test_scopingGood "renaming" genProgram BindingRemovalNotOk PrerenameNo $ | ||
| , T.test_scopingGood "renaming" genProgram T.BindingRemovalNotOk T.PrerenameNo $ |
There was a problem hiding this comment.
It's there for consistency, I think I'm fine with it.
thealmarty
reviewed
Oct 2, 2023
| Inline.inline mempty def | ||
| , test_scopingGood "match-against-known-constructor" genTerm BindingRemovalNotOk PrerenameNo $ | ||
| , T.test_scopingGood "match-against-known-constructor" genTerm T.BindingRemovalNotOk T.PrerenameNo $ |
thealmarty
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Awesome! Thanks!
Just some linter suggestions e.g. redundant bracket for inQuotedName.
Are you still considering the other approach of putting the tests right in src?
Apparently it doesn't work as well as I'd thought it might. Also, if we did want to do it, it would be quite easy to do on top of this: just merge the source folders! So this gets us 90% of the way there regardless. |
I'm not going to fix all the lint suggestions in the tests, that's a whole thing in itself 😅 |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restructures the tests for PIR following the discussion we had before. Just the test-naming and tasty-discover bits so far. I'll do UPLC and TPLC later.