Add some comments on FromBuiltin/ToBuiltin/Lift #5585
Conversation
| For some functions we have two conflicting desires: | ||
| - We want to have the unfolding available for the plugin. | ||
| - We don't want the function to *actually* get inlined before the plugin runs, since we rely | ||
| on being able to see the original function for some reason. | ||
|
|
||
| 'INLINABLE' achieves the first, but may cause the function to be inlined too soon. |
There was a problem hiding this comment.
I remember RV having a somewhat similar problem. I think the solution I came up at the time was to turn
f = body
{-# INLINEABLE f #-}into
f = res where
res = body
{-# NOINLINE res #-}
{-# INLINE f #-}Might want to try it here?
There was a problem hiding this comment.
Yeah, although the current hack has worked okay for some time.
| for types that don't have a separate "normall Haskell" version. For example: | ||
| integer. Integer in Plutus Tx user code _is_ the opaque builtin type, we don't | ||
| expose a different one. Essentially: if it's a datatype then there's a substantive | ||
| conversion. |
There was a problem hiding this comment.
This sounds like we have two cases:
BoolvsBuiltinBool-- Plutus Tx type vs built-in type, both appear in theToBuiltin/FromBuiltininstanceIntegervsBuiltinInteger-- Plutus Tx type and built-in type, both appear in theToBuiltin/FromBuiltininstance
but we actually have a third one:
DatavsBuiltinData-- Plutus Tx type vs built-in type, only the latter appears in theToBuiltin/FromBuiltininstance
So this Note doesn't clarify this particular quirk for me.
@zliu41 did provide some explanations in slack, so could you please incorporate those if you agree with them?
There was a problem hiding this comment.
Hmm, I agree that the Data case is odd. I am actually not sure why it's like that. I'm going to try changing it and see what breaks.
There was a problem hiding this comment.
It's actually quite odd, I'm trying to pin down how it should work.
| -} | ||
|
|
||
| {- Note [Strict conversions to/from unit] | ||
| Converting to/from unit *should* be straightforward: just ``const ()`.` |
There was a problem hiding this comment.
| Converting to/from unit *should* be straightforward: just ``const ()`.` | |
| Converting to/from unit *should* be straightforward: just `const ()`. |
michaelpj
force-pushed
the
mpj/builtins-notes
branch
from
e55125a
to
828054f
Compare
michaelpj
force-pushed
the
mpj/builtins-notes
branch
from
828054f
to
5d7ea0a
Compare
Hopefully this helps a bit.