Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin] Warn about missing builtins #5702

Merged

Conversation

effectfully
Copy link
Contributor

This makes it so that an unhandled built-in function in the plugin causes a compile-time warning.

In particular, it gives me

warning: [GHC-62161] [-Wincomplete-patterns]
    Pattern match(es) are non-exhaustive
    In a case alternative:
        Patterns of type ‘PLC.DefaultFun’ not matched:
            PLC.IntegerToByteString
            PLC.ByteStringToInteger

@michaelpj
Copy link
Contributor

Are you also going to fix the missing builtins?

@michaelpj
Copy link
Contributor

I pushed the fixes

@effectfully
Copy link
Contributor Author

Eek, I told @kwxm I'd just wait for him to complete his work and only merge my PR afterwards as it's not important and this seemed to be the simplest strategy. But feel free to merge, I guess.

There are build errors BTW.

@michaelpj
Copy link
Contributor

IDK, seems well worth it and it works now 🤷

@michaelpj michaelpj merged commit 745f54e into master Jan 11, 2024
3 of 4 checks passed
@michaelpj michaelpj deleted the effectfully/plutus-tx-plugin/warn-about-missing-builtins branch January 11, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants