Skip to content

Update index-states and qualify 2 imports #7333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 12, 2025
Merged

Update index-states and qualify 2 imports #7333

merged 2 commits into from
Sep 12, 2025

Conversation

@erikd
Copy link
Contributor

@erikd erikd commented Sep 12, 2025

Needed to fully qualify the Set and Map imports because there were name clashes in a WIP branch I am working on (preliminary ghc-9.14 support).

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Changelog fragments have been written (if appropriate)
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • (For external contributions) Corresponding issue exists and is linked in the description
    • Targeting master unless this is a cherry-pick backport
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@erikd erikd requested review from ana-pantilie and coot September 12, 2025 03:42
erikd
erikd commented Sep 12, 2025
View reviewed changes
plutus-core/plutus-core/src/PlutusCore/Check/Scoping.hs
import Data.Set as Set
import Data.Set (Set)
import Data.Set qualified as Set
import Text.Pretty
Copy link
Contributor Author

@erikd erikd Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without qualifying these imports I was getting name clashes on another branch of mine.

erikd
erikd commented Sep 12, 2025
View reviewed changes
plutus-ledger-api/plutus-ledger-api.cabal
, mtl
, nothunks
, nothunks ^>=0.2
, plutus-core ^>=1.53
Copy link
Contributor Author

@erikd erikd Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, was pulling in version 0.3.* which has an API change.

@erikd erikd self-assigned this Sep 12, 2025
@erikd erikd added the No Changelog Required Add this to skip the Changelog Check label Sep 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://IntersectMBO.github.io/plutus/pr-preview/pr-7333/

Built to branch gh-pages at 2025-09-12 04:13 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

ana-pantilie
ana-pantilie approved these changes Sep 12, 2025
View reviewed changes
Copy link
Contributor

@ana-pantilie ana-pantilie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ana-pantilie ana-pantilie merged commit b010374 into master Sep 12, 2025
6 of 7 checks passed
@ana-pantilie ana-pantilie deleted the erikd/index-states branch September 12, 2025 08:13
Unisay pushed a commit that referenced this pull request Oct 1, 2025
@erikd @Unisay
Update index-states and qualify 2 imports (#7333)
68be3c0 
* Update index-states and qualify 2 imports

* Nix updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ana-pantilie ana-pantilie ana-pantilie approved these changes

@coot coot Awaiting requested review from coot

Assignees

@erikd erikd

Labels

No Changelog Required Add this to skip the Changelog Check

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erikd @ana-pantilie