use-cases: Add multi sig contract #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-mueller
force-pushed
the
j-mueller/792-multi-sig
branch
from
344c8ab
to
b7aca70
Compare
michaelpj
reviewed
Apr 4, 2019
| let | ||
| present = $$(P.length) ($$(P.filter) ($$(V.txSignedBy) p) keys) | ||
| in | ||
| if $$(P.geq) present num |
There was a problem hiding this comment.
For illustration perhaps it would be nice to log the keys that were present and those that weren't or something?
There was a problem hiding this comment.
I don't think we can log them from on-chain code (we'd need to to base16-encode them and then convert to a string) but I'll have a look
There was a problem hiding this comment.
A way to convert bytestrings into strings on chain would be nice.
plutus-use-cases/src/Language/PlutusTx/Coordination/Contracts/MultiSig.hs
Show resolved
Hide resolved
plutus-use-cases/src/Language/PlutusTx/Coordination/Contracts/MultiSig.hs
Outdated
Show resolved
Hide resolved
plutus-use-cases/src/Language/PlutusTx/Coordination/Contracts/MultiSig.hs
Outdated
Show resolved
Hide resolved
j-mueller
force-pushed
the
j-mueller/792-multi-sig
branch
7 times, most recently
from
3efb2e8
to
0c5aa8f
Compare
mchakravarty
approved these changes
Apr 5, 2019
Add `runWalletAction` to get the return value of the wallet action.
j-mueller
force-pushed
the
j-mueller/792-multi-sig
branch
from
0c5aa8f
to
4d22843
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the simple multisig contract, where the spending transaction needs to be passed around via a separate channel.