-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When you trigger an error in the sass task the watcher gets stuck. #26
Comments
Hmm, I can't reproduce that. Could you scope where things go wrong? |
@MartijnCuppens yeah I was planning on debugging it. Just created an issue so I can keep track of the progress. |
I've setup a repo where you can reproduce the issues. Just run the buildozer watch command and uncomment https://github.com/gijsroge/plumber-sass-watch-issue/blob/master/scss/subfolder/_test.scss#L3 It only happens if you import a file from a subfolder that triggers an error .. 🤷♂️ Found a couple of related issues. The quick fix is to implement a custom errorHandler that emits an 'end' event. Looks like we have 2 options available. Whats your opinion? |
Maybe #22 causes this. I think we better figure out how to fix that issue first, solving that might solve this (not sure at all, but I know for sure are callbacks are currently not ok) |
🎉 🎉 |
If you have an error you in your sass files the build throws an error but does not recompile after you fix the issue.
This forces you too re trigger the watch task each time you make a mistake.
Not sure whats causing this.
The text was updated successfully, but these errors were encountered: