Add ability to load custom PostCSS plugins #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getPostCSSConfiguration function was not blocking therefore the gulp-postcss instance was called before the config was loaded. This caused gulp-postcss to search for the config itself and throw an error that we did not catch when the user did not have a config.
gijsroge
commented
Oct 2, 2019
Comment on lines
+35
to
+36
| async function cssCompile({src, dest, minified = true, browserSync = false}) { | ||
| const {plugins, options = {}} = await getPostCSSConfiguration(minified); |
There was a problem hiding this comment.
I found the little culprit..
The function that loads the PostCSS config wasn't called in a blocking way so it continued and tried to initiate gulp-postcss before actually getting the PostCSS config therefore gulp-postcss threw an error that I didin't handle.
Now that its blocking there is always a config available. Either the config from the user or the default one we provide.
MartijnCuppens
approved these changes
Oct 3, 2019
MartijnCuppens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.