Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rollup #179

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Feature/rollup #179

wants to merge 4 commits into from

Conversation

gijsroge
Copy link
Member

@gijsroge gijsroge commented May 25, 2020

Still in draft, please refrain from reviewing WIP.

This pull request introduces Rollup to allow for bundling of JavaScript.

  • This allows you to import first/third party modules from any JavaScript file.
  • Allows us to easily integrate features like; TypeScript, outputing manifests, dynamic imports (for lazy loading modules).

Breaking changes:

  • JavaScript outputs is always scoped, never global
  • Same counts for the concatenated files
  • Outputs a flat structure. If the source file is in sub/sub/sub/a.js it outputs -> dist/js

Progress:

@MartijnCuppens
Copy link
Contributor

Do we even need js-concat, since we can now merge the files with the import (can we, not sure?)?

We can't keep

js:
- src: js/**/*.js
dest: dist/js

since this will generate a separate js file for each js file. Thoughts on changing this to:

js:
  - src: js/**/index.js
    dest: dist/js

@gijsroge
Copy link
Member Author

Small follow up. Did not have much time last couple of months. Planning on picking this back up soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants