-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
broken feather icons #8
Comments
It looks like this problem is deeper than just setting attributes, the reason d is undefined is because the Feather set is being imported from node modules which works fine for some other sets, but Feather is not built like other icon sets. For most Feather icons they are using different tags than just path like polyline, circle, line so naturally the d attribute is undefined since these other tags don't use path commands. This project only returns a path and doesn't anticipate other tags:
The only fix would be to write an entirely different set of rules in build.ts for reading and displaying Feather Icons, or to make an alternate set of Feather Icons by running them through SVGOMG or editing in Inkscape or Illustrator to expand the strokes so they have a consistent path tag. Other than that I think Feather should be removed, it's non-standard and needs it's own Svelte-based project. |
I will look into this soon, I don't think excluding an icon set is a good solution, even if there is changes needed to the build step, the project is meant to be a collection of icon sets. |
this set is causing some issues so it will be removed for the time being, see #8 for more details BREAKING CHANGE: the feather icon set (/fi) will is no longer available
I will however remove them for the time being and will keep this issue open to track an enhancement. |
As seen on https://www.svelte-icons.gibdig.com/, the complete feather-icon-set is displayed wrong.
Possible solutions might be:
stroke-width
fill
to none..only for this set
Also the majority of
d
attributes of thepath
tags are set to "undefined"The text was updated successfully, but these errors were encountered: