Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken feather icons #8

Closed
JustinVoitel opened this issue Sep 30, 2019 · 3 comments
Closed

broken feather icons #8

JustinVoitel opened this issue Sep 30, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request package

Comments

@JustinVoitel
Copy link

JustinVoitel commented Sep 30, 2019

As seen on https://www.svelte-icons.gibdig.com/, the complete feather-icon-set is displayed wrong.
Possible solutions might be:

  • setting stroke-width
  • setting fill to none

..only for this set

Also the majority of d attributes of the path tags are set to "undefined"

@JHethDev
Copy link

It looks like this problem is deeper than just setting attributes, the reason d is undefined is because the Feather set is being imported from node modules which works fine for some other sets, but Feather is not built like other icon sets. For most Feather icons they are using different tags than just path like polyline, circle, line so naturally the d attribute is undefined since these other tags don't use path commands.

This project only returns a path and doesn't anticipate other tags:

const svgContent = child
  .map(({ attr }) => {
    const { d } = attr;
    return `<path d="${d}" />`;
  })
  .join('\n');

The only fix would be to write an entirely different set of rules in build.ts for reading and displaying Feather Icons, or to make an alternate set of Feather Icons by running them through SVGOMG or editing in Inkscape or Illustrator to expand the strokes so they have a consistent path tag. Other than that I think Feather should be removed, it's non-standard and needs it's own Svelte-based project.

@AnxiousDarkly
Copy link
Collaborator

I will look into this soon, I don't think excluding an icon set is a good solution, even if there is changes needed to the build step, the project is meant to be a collection of icon sets.

@AnxiousDarkly AnxiousDarkly added bug Something isn't working package labels Mar 6, 2020
AnxiousDarkly pushed a commit that referenced this issue Mar 7, 2020
this set is causing some issues so it will be removed for the time being, see
#8 for more details

BREAKING CHANGE: the feather icon set (/fi) will is no longer available
@AnxiousDarkly
Copy link
Collaborator

I will however remove them for the time being and will keep this issue open to track an enhancement.

4dc686c

@AnxiousDarkly AnxiousDarkly added enhancement New feature or request and removed bug Something isn't working labels Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request package
Projects
None yet
Development

No branches or pull requests

3 participants