New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes timestamp serialization issue (#170) #171

Merged

Inumedia merged 1 commit into Inumedia:master from snechaev:master

Mar 14, 2019

snechaev commented Mar 12, 2019

This should fix #170. The changes are:

Using invariant culture to serialize timestamps
Corresponding change to the Assert expression (the expression relates on the timestamp serialization options).


          Fixes timestamp serialization issue (#170)

0948bad

Owner

Inumedia commented Mar 12, 2019

Can you confirm that this works with .netcore?

Author

snechaev commented Mar 12, 2019

Yes, it should work on .netcore. According to MSDN, DateTime.ToString(String, IFormatProvider) and DateTime.ToString(IFormatProvider) overloads are available starting from .net core 1.0 as well as CultureInfo.InvariantCulture property (see https://docs.microsoft.com/en-us/dotnet/api/system.globalization.cultureinfo.invariantculture?view=netcore-1.0 and https://docs.microsoft.com/en-us/dotnet/api/system.datetime.tostring?view=netcore-1.0#System_DateTime_ToString_System_String_System_IFormatProvider_)

Collaborator

gpailler commented Mar 12, 2019

The AppVeyor build is ok so it should work properly with .net core

Inumedia approved these changes

View reviewed changes

Inumedia merged commit 4400f78 into Inumedia:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet