Added conversations.list endpoint functionality and cursor request parameter functionality in base response class. #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rameter functionality in base response class.
alexherreid
approved these changes
Sep 10, 2020
There was a problem hiding this comment.
FWIW, I grabbed these changes and they work as advertised with the new conversations endpoint as well as the issue that I attempted to fix in rejected PR #231
alexherreid
added a commit
to alexherreid/SlackAPI
that referenced
this pull request
Sep 11, 2020
Expands the use of conversations to use an enum when specifying request instead of pure string. Expands on Inumedia#250
Inumedia
reviewed
Sep 12, 2020
|
The requested indentation issue was resolved. Are these changes good to go? |
Inumedia
reviewed
Sep 29, 2020
There was a problem hiding this comment.
Hi, thanks for reminding me to look at this again.
I double checked the changes and noticed one of the new calls creates the Tuples for the parameters but never actually adds it to the list. Once that's done this can be approved and will just need to wait for me to merge + deploy the new nuget package
Inumedia
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Issue #242
Resolves original bug identified in Pull Request #231