Multiple fixes and code formatting #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! I will give this a look as soon as I can! And yes I totally prefer Black as well 👍 |
|
@NefixEstrada I'm not sure I resolved the conflicts correctly, do you mind taking a look? |
NefixEstrada
commented
Aug 26, 2023
NefixEstrada
commented
Aug 26, 2023
hope you had a nice vacation!
ah yeah I see it now! thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again!
I've fixed some issues with the existing functions (missing edge cases mainly), and written some texts!
Also, I noticed that there was a linter but wasn't enforcing anything, so I switched to black and formatted the whole repo.
If you don't like the formatting part, I can remove it, but I thought it would be nice to enforce the same style always!
Thanks