Hide print button in orders listing page #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GytisZum
commented
Sep 14, 2023
GytisZum
commented
tomjas1997
reviewed
Sep 14, 2023
| @@ -114,6 +114,21 @@ protected function initOptions() | |||
| 'title' => $this->l('Save'), | |||
| ], | |||
| ], | |||
| 'orders_page_configuration' => [ | |||
| 'title' => $this->l('Orders listing page configuration'), | |||
There was a problem hiding this comment.
missing FILE_NAME and use module.
$this->module->l('Save', self::FILE_NAME),
tomjas1997
reviewed
Sep 14, 2023
| @@ -1267,6 +1273,7 @@ public function hookActionOrderGridDefinitionModifier(array $params) | |||
|
|
|||
| $definition = $params['definition']; | |||
|
|
|||
| if (!(bool) Configuration::get(Config::HIDE_ORDERS_LABEL_PRINT_BUTTON)) { | |||
There was a problem hiding this comment.
Allowing bulk actions, but removed singular?
There was a problem hiding this comment.
We got approvement that we hide button only and keeping bulk actions
…abel-print-feature
tomjas1997
reviewed
Dec 11, 2023
| @@ -220,6 +220,7 @@ public function getDefaultConfiguration() | |||
| Config::IMPORT_LINES_SKIP => 1, | |||
| Config::IMPORT_FIELD_SEPARATOR => ';', | |||
| Config::IMPORT_DELETE_OLD_DATA => 0, | |||
| Config::HIDE_ORDERS_LABEL_PRINT_BUTTON => 0, | |||
tomjas1997
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.